Fix generation of "sombok" makefile #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with ExtUtils-MakeMaker v7.35_05 (Perl 5.31.1 and later), makefiles generated for MSVC specify the path to the pdb file as the makefile 'stem' ($*) of the object file being compiled ('.o' extension is replaced with '.pdb'. (this allows parallel compilation). However, Unicode-LineBreak's "sombok" makefile generator incompletely rewrites the suffix rules generated by MakeMaker to attempt to account for the sombok library's code layout. This results in MSVC attempting to write to a non-existant path (cannot open program database '...\sombok\lib\lib\break.pdb').
Instead of attempting to write another substitution pattern for the new 'pdb' paths:
1. remove the rewrites that changes directory and adjusts the paths to the files
2. when calling the MM method that generates the suffix rules, temporarily force on a flag that causes the rules to include the compiler option that specifies the complete path to the object file.
This keeps the derived files in the expected locations.
https://rt.cpan.org/Ticket/Display.html?id=143360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with ExtUtils-MakeMaker v7.35_05 (Perl 5.31.1 and later), makefiles generated for MSVC specify the path to the pdb file as the makefile 'stem' ($*) of the object file being compiled ('.o' extension is replaced with '.pdb'. (this allows parallel compilation). However, Unicode-LineBreak's "sombok" makefile generator incompletely rewrites the suffix rules generated by MakeMaker to attempt to account for the sombok library's code layout. This results in MSVC attempting to write to a non-existant path (cannot open program database '...\sombok\lib\lib\break.pdb').
Instead of attempting to write another substitution pattern for the new 'pdb' paths:
This keeps the derived files in the expected locations.
https://rt.cpan.org/Ticket/Display.html?id=143360