Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add omit-labels functionality [DOC-268] #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add omit-labels functionality [DOC-268] #15

wants to merge 1 commit into from
+11 −3

Conversation

JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Nov 22, 2024 •
edited by jira bot
Loading

When backports are triggered via PR labels, copying the labels to the backport PRs can cause an unexpected cascade.

E.G.:

  • a PR is labelled to backport to multiple branches
  • an action performs these actions in parallel
  • the backported, labelled PRs are detected
  • more backporting is performed
  • etc

Instead it would be easier to optionally omit copying labels to backported PRs.

Fixes: DOC-268

@JackPGreen
Add omit-labels functionality [DOC-268]
cd94c01 
When backports are triggered via PR labels, copying the labels to the backport PRs can cause an unexpected cascade.

E.G.:
- a PR is labelled to backport to multiple branches
- an action performs these actions _in parallel_
- the backported, labelled PRs are detected
- more backporting is performed
- etc

Instead it would be easier to _optionally_ omit copying labels to backported PRs.

Fixes: [DOC-268](https://hazelcast.atlassian.net/browse/DOC-268)
@JackPGreen JackPGreen self-assigned this Nov 22, 2024
@JackPGreen JackPGreen mentioned this pull request Nov 22, 2024
Open
ldziedziul
ldziedziul reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@ldziedziul ldziedziul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to omit labels completely when the backport is triggered by the label?

@JackPGreen
Copy link
Contributor Author

Do you want to omit labels completely when the backport is triggered by the label?

I don’t think I can detect that - in hz-docs it’s triggered by a push containing a specified label.

@ldziedziul
Copy link
Collaborator

I mean what's your plan for fixing this issue on the workflow side?

@JackPGreen
Copy link
Contributor Author

I mean what's your plan for fixing this issue on the workflow side?

I don't have one. You can see my idea here. Ideas welcomed.

@ldziedziul
Copy link
Collaborator

ldziedziul commented Nov 22, 2024 •
edited
Loading

I mean what's your plan for fixing this issue on the workflow side?

I don't have one. You can see my idea here. Ideas welcomed.

Sorry, I can't see where's the loop? The workflow is triggered by workflow_call so labels won't trigger it

@JackPGreen
Copy link
Contributor Author

I mean what's your plan for fixing this issue on the workflow side?

I don't have one. You can see my idea here. Ideas welcomed.

Sorry, I can't see where's the loop? The workflow is triggered by workflow_call so labels won't trigger it

There's an inverse action that forwardports commits to main, calling the same workflow.

Even if it's not possible today, labels aren't really used in hz-docs and I'm happy to skip them to avoid the risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldziedziul ldziedziul ldziedziul left review comments

Assignees

@JackPGreen JackPGreen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackPGreen @ldziedziul