Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CP Group Name in CP Objects [API-2252] #913

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

emreyigit
Copy link
Collaborator

@emreyigit emreyigit commented Aug 6, 2024

The PR fixes wrong usage of CP groups. Before the introduced fix, the client was sending the CP group creation requests in wrong format. This was resulting that all CP objects created in default CP group. Now, it's fixed.

@emreyigit emreyigit self-assigned this Aug 6, 2024
@emreyigit emreyigit added Priority: Critical Critical Priority. Type: Defect Issue is a Defect ie a Bug that needs to be fixed. labels Aug 6, 2024
@emreyigit emreyigit added this to the 5.5 milestone Aug 6, 2024
@emreyigit emreyigit requested a review from Patras3 August 6, 2024 13:38
Patras3
Patras3 previously approved these changes Aug 6, 2024
Copy link

@Patras3 Patras3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (a00048c) to head (0a8cc02).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/Hazelcast.Net/CP/CPSubsystem.cs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   81.07%   80.98%   -0.10%     
==========================================
  Files        1031     1031              
  Lines       25047    25047              
==========================================
- Hits        20307    20284      -23     
- Misses       4740     4763      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emreyigit emreyigit merged commit ddbedf3 into hazelcast:master Aug 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical Critical Priority. Type: Defect Issue is a Defect ie a Bug that needs to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants