-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS
to use documentation
group [DOC-256]
#419
Open
JackPGreen
wants to merge
11
commits into
hazelcast:main
Choose a base branch
from
JackPGreen:Update-`CODEOWNERS`-to-use-`documentation`-group-DOC-256]
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update CODEOWNERS
to use documentation
group [DOC-256]
#419
JackPGreen
wants to merge
11
commits into
hazelcast:main
from
JackPGreen:Update-`CODEOWNERS`-to-use-`documentation`-group-DOC-256]
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description of change Please write a summary of your changes and why you made them. Be sure to reference any related issues by adding `fixes #(issue)`. ## Type of change Select the type of change that you're making: - [ ] Bug fix (Addresses an issue in existing content such as a typo) - [ ] Enhancement (Adds new content) ## Open Questions and Pre-Merge TODOs - [ ] Use github checklists to create a list. When an item is solved, check the box and explain the answer.
# Description of change Align `antora-playbook-local.yml` according to `antora-playbook.yml` formatting Sort antora-aggregate-collector componentversions by name and version to simplify mc docs update automation and reduce conflicts. Update release branches to the latest versions
# Description of change 1. Adds two files which will be reused across other docs repos for global links check 2. As a BONUS remove an unexisting reference from `templates/antora.yml`
Adds Readme for new links-checker mechanism --------- Signed-off-by: devOpsHelm <[email protected]> Co-authored-by: Oliver Howell <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: devopshazelcast <[email protected]> Co-authored-by: devOpsHelm <[email protected]> Co-authored-by: Nishaat Rajabali <[email protected]> Co-authored-by: Yüce Tekol <[email protected]>
Old docs branches don't have the library `@jcahills/antora-link-checker` installed, so need to install it in the common action --------- Signed-off-by: devOpsHelm <[email protected]> Co-authored-by: Oliver Howell <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: devopshazelcast <[email protected]> Co-authored-by: devOpsHelm <[email protected]> Co-authored-by: Nishaat Rajabali <[email protected]> Co-authored-by: Yüce Tekol <[email protected]>
Previously the `docs` start_path was always added to the PR's branch source. But it doesn't work for sources (e.g. `cloud-docs`) where we have multiple `start_paths`. ``` - url: https://github.com/hazelcast/cloud-docs branches: [main] start_paths: [docs, tutorials] ``` --------- Signed-off-by: devOpsHelm <[email protected]> Co-authored-by: Oliver Howell <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: devopshazelcast <[email protected]> Co-authored-by: devOpsHelm <[email protected]> Co-authored-by: Nishaat Rajabali <[email protected]> Co-authored-by: Yüce Tekol <[email protected]>
Ensure consistency across all doc repos Fixes: [DOC-256](https://hazelcast.atlassian.net/browse/DOC-256)
JackPGreen
requested review from
oliverhowell,
amandalindsay and
Rob-Hazelcast
as code owners
November 19, 2024 23:52
fantkolja
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure consistency across all doc repos
Fixes: DOC-256