Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX feedback on protobuf import #76

Merged
merged 1 commit into from
Nov 7, 2024
Merged

UX feedback on protobuf import #76

merged 1 commit into from
Nov 7, 2024

Conversation

pmcgleenon
Copy link
Contributor

Description of change

Updated the steps for the protobuf import to make it clearer.
Also added a note on the kafka import in case the protobuf imported type is missing

@pmcgleenon pmcgleenon requested review from pollett and a team as code owners November 6, 2024 16:31
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for silly-otter-82acc9 ready!

Name Link
🔨 Latest commit 3bb25bc
🔍 Latest deploy log https://app.netlify.com/sites/silly-otter-82acc9/deploys/672c9a450e86ac0008fe97ce
😎 Deploy Preview https://deploy-preview-76--silly-otter-82acc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmcgleenon pmcgleenon changed the base branch from main to staging November 6, 2024 16:32
@pmcgleenon pmcgleenon force-pushed the ux-feedback branch 2 times, most recently from 8ff439b to 8ca1e14 Compare November 6, 2024 16:44
Copy link
Collaborator

@amandalindsay amandalindsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pmcgleenon pmcgleenon changed the base branch from staging to main November 7, 2024 10:31
@pmcgleenon pmcgleenon merged commit b2c7e6d into main Nov 7, 2024
5 of 6 checks passed
@pmcgleenon pmcgleenon deleted the ux-feedback branch November 7, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants