Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): Add TEST_ANALYTICS check and switch to Codecov uploads #31

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hckhanh
Copy link
Owner

@hckhanh hckhanh commented Dec 2, 2024

In vitest.config.ts, added conditional logic to use JUnit reporting when TEST_ANALYTICS is set, and specified an output file for the JUnit report. In the GitHub Actions workflow, switched from Codacy to Codecov for uploading coverage reports and added a step to upload test results with JUnit output. These updates aim to improve test analytics and integration with Codecov.

Summary by Sourcery

Improve test analytics by switching from Codacy to Codecov for coverage uploads and adding JUnit test result uploads. Update vitest.config.ts to conditionally use JUnit reporting based on TEST_ANALYTICS environment variable.

Enhancements:

  • Add conditional logic in vitest.config.ts to use JUnit reporting when TEST_ANALYTICS is set.

CI:

  • Switch from Codacy to Codecov for uploading coverage reports in the GitHub Actions workflow.
  • Add a step to upload test results with JUnit output to Codecov in the GitHub Actions workflow.

In `vitest.config.ts`, added conditional logic to use JUnit reporting when `TEST_ANALYTICS` is set, and specified an output file for the JUnit report. In the GitHub Actions workflow, switched from Codacy to Codecov for uploading coverage reports and added a step to upload test results with JUnit output. These updates aim to improve test analytics and integration with Codecov.
@hckhanh hckhanh self-assigned this Dec 2, 2024
Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

The PR implements test analytics improvements by configuring JUnit reporting and switching from Codacy to Codecov for coverage reporting. The changes involve conditional configuration in Vitest and updates to the GitHub Actions workflow to handle test result uploads.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added conditional JUnit test reporting configuration
  • Added TEST_ANALYTICS environment variable check to enable JUnit reporting
  • Configured output file path for JUnit reports
  • Maintained existing dot and github-actions reporters
vitest.config.ts
Migrated from Codacy to Codecov for test coverage reporting
  • Removed Codacy coverage reporter action
  • Added Codecov coverage upload action
  • Added separate step for uploading JUnit test results to Codecov
  • Added TEST_ANALYTICS environment variable to test run
.github/workflows/tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hckhanh hckhanh enabled auto-merge (squash) December 2, 2024 03:06
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hckhanh - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hckhanh hckhanh merged commit d197001 into main Dec 2, 2024
10 of 11 checks passed
@hckhanh hckhanh deleted the codecov branch December 2, 2024 03:07
Copy link

codecov bot commented Dec 2, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant