-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testing): Switch coverage reporting from Codecov to SonarCloud #34
Conversation
Replace Codecov integrations with SonarCloud for coverage reporting and static code analysis. Add `sonar-project.properties` to configure SonarCloud reporting paths. Update GitHub Actions workflow to execute SonarCloud scans, removing Codecov steps.
This commit introduces a new step to run ESLint checks in the GitHub Actions workflow. Running ESLint ensures code quality by identifying and fixing problems in the JavaScript codebase before tests and scans are executed.
Reviewer's Guide by SourceryThis PR transitions the project's code coverage and analysis tooling from Codecov to SonarCloud. The implementation involves removing Codecov-related GitHub Actions steps, configuring SonarCloud properties, and adjusting the test reporting formats to match SonarCloud's requirements. The changes also include adding ESLint JSON reporting to integrate with SonarCloud's static analysis capabilities. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hckhanh - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Corrected the token environment variable name from 'SONARCLOUD_TOKEN' to 'SONAR_TOKEN' to ensure proper authentication for the SonarCloud Scan step. This change addresses an issue with the token assignment, enabling successful scanning in the CI workflow.
The job previously named 'coverage' has been renamed to 'analytics' for clearer representation of its function in the CI workflow. This change aims to better align the job's name with its role in processing and reporting data. No functional changes to the workflow steps are involved.
This change modifies the checkout step to include a fetch-depth of 0, ensuring that the full commit history is available for the workflow. This adjustment is necessary for operations that require access to complete commit data, such as calculating versioning information or generating changelogs.
Removed unnecessary "./" prefix from file path configurations in sonar-project.properties. This change streamlines path references and ensures consistency across project settings.
Quality Gate passedIssues Measures |
Replace Codecov integrations with SonarCloud for coverage reporting and static code analysis. Add
sonar-project.properties
to configure SonarCloud reporting paths. Update GitHub Actions workflow to execute SonarCloud scans, removing Codecov steps.Summary by Sourcery
Replace Codecov with SonarCloud for coverage reporting and static code analysis, updating GitHub Actions workflow and configuration files accordingly.
CI:
Documentation:
Chores: