Smaller footprint #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanforce
force-pushed
the
nf/codegen-smol
branch
from
9ee8941 to
965a94e
Compare
chadfranzen
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some rather large changes to our output templates in an effort to reduce the overall footprint of the generated javascript.
hasInputParamswhich checks if there are any body, form, query, or path params.client.mustachewhich creates a correspondingclient.ts. This is used to generate a singleton that handles all fetching logic.api.mustachesuch that the apis generated in/resourcesimport and use the client generated inclient.tsrather than repeating the same structure across all request functions.Related PR https://github.com/headway/headway/pull/7171