Form Component #151

qial · 2020-08-19T18:30:37Z

What does this implement/fix? Explain your changes.
Will solve #136 by updating the form component to be more useable.

…sues

… objects on the window

…ect cant be found

reusr1

we are missing a way to tell the author that the form schema is invalid while working on the schema
we need better samples
general code cleanup as mentioned in the review

fragments/form/model.json

fragments/form/sample-contact.json

fragments/form/model.json

fragments/form/sample.json

fragments/form/template.html

fragments/form/template.vue

…o console.log, removed id from failure message div

fragments/form/model.json

…ng from error paragraphs

…dler for forms

…n-flex into issues/136

smcgrath0 · 2020-08-24T20:29:51Z

Added styles to this component. And removed depublicate submit button in all-inputs schema.

smcgrath0 · 2020-08-24T22:33:37Z

Component now allows button to be aligned left/center/right, and ability to change size

…n-flex into issues/136

into issues/136

qial · 2020-09-05T00:10:26Z

I am closing this in favor of directly pulling in the issues/156 branch in the pull request 162

reusr1 and others added 10 commits August 12, 2020 12:05

introduction of a forms component

c7e6576

Added success page and failure message dialog options

eec8db3

Added more options to Form's model

e3cb545

Updated form component with test submit code

f0b255b

Updated form to use javascript function correctly and fixed dialog is…

289a91e

…sues

Fixed failure message coming through

d4dc94d

Updated submitfunction workings

cbfe6d7

Updated submitfunction to correctly handle all forms of functions and…

2bb5e16

… objects on the window

Fixed functions inside of objects, but doesn't fail well when the obj…

74bb4e7

…ect cant be found

Fixed functions inside nested objects in the submitfunction dialog

07ce128

reusr1 requested changes Aug 20, 2020

View reviewed changes

qial added 4 commits August 20, 2020 09:54

Changed defaultSubmit to onSubmit, changed function not found alert t…

77057b8

…o console.log, removed id from failure message div

Fixed some styling issues, cleaned up form dialog with hints

fd9728f

Updated onSubmit closure to better format so 'this' is carried over

5152f32

Cleaned up useless cases in the submit function loop

88ca794

reusr1 reviewed Aug 20, 2020

View reviewed changes

fragments/form/model.json Outdated Show resolved Hide resolved

qial and others added 12 commits August 20, 2020 14:32

Updated error messages for bad json in the form field model

75dcf2f

Added _blank target to form model docs link, and removed inline editi…

0196f01

…ng from error paragraphs

poc style implementation of a data list component and a save/load han…

9c83f7b

…dler for forms

Merge branch 'issues/136' of https://github.com/headwirecom/themeclea…

35849d3

…n-flex into issues/136

Updated form samples and added sample-all with all supported inputs

ce28f34

Updated sample content to fix jcr import error

99450b8

#136 added styles to error messages and submit btn

4184cc1

Fixed Submit button text and other issues with formatting

ba6e404

#136 added transition for error message

77c84f1

#136 added submit button in all example schemas and removed in markup

6ae0a1c

Merge branch 'issues/136' of https://github.com/headwirecom/themeclea…

b44317b

…n-flex into issues/136

#136 added styles for all inputs

f247851

#136 added button alignment and size dialog/styling

9c24c09

smcgrath0 and others added 7 commits August 25, 2020 08:57

#136 fixed class string/fixed font on textarea/select

3862af1

updated inline settings for failure messages

e7da0a8

Added groups to the input type sample form

5dac11f

#136 fixed form alignment issue/group styling/checkbox alignment

3fb9e95

#136 dialog button size: sm,lg -> small, large

2e29646

Merge branch 'issues/136' of https://github.com/headwirecom/themeclea…

797f0f0

…n-flex into issues/136

#136 removed form error transition

51c8a9c

qial linked an issue Sep 4, 2020 that may be closed by this pull request

form component #136

Open

qial changed the title ~~Form Component Updates~~ Form Component and Datalist Component Sep 4, 2020

qial and others added 3 commits September 4, 2020 13:01

Merge remote-tracking branch 'upstream/issues/136' into issues/136

fe2c405

#136 removing a final setTimeout on the error message

056aa96

Merge branch 'develop' of https://github.com/headwirecom/themeclean-flex

c53e69d

into issues/136

qial changed the title ~~Form Component and Datalist Component~~ Form Component Sep 4, 2020

qial mentioned this pull request Sep 5, 2020

New Form and Datalist component #162

Draft

qial closed this Sep 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form Component #151

Form Component #151

qial commented Aug 19, 2020

reusr1 left a comment

smcgrath0 commented Aug 24, 2020

smcgrath0 commented Aug 24, 2020

qial commented Sep 5, 2020

Form Component #151

Form Component #151

Conversation

qial commented Aug 19, 2020

reusr1 left a comment

Choose a reason for hiding this comment

smcgrath0 commented Aug 24, 2020

smcgrath0 commented Aug 24, 2020

qial commented Sep 5, 2020