Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsonforms for form component #181

Merged
merged 113 commits into from
Apr 26, 2021
Merged

Jsonforms for form component #181

merged 113 commits into from
Apr 26, 2021

Conversation

flx-sta
Copy link
Collaborator

@flx-sta flx-sta commented Mar 25, 2021 •
edited
Loading

Known "Issues"

Closes #179

reusr1 and others added 30 commits August 12, 2020 12:05
@reusr1
introduction of a forms component
c7e6576
@qial
Added success page and failure message dialog options
eec8db3
@qial
Added more options to Form's model
e3cb545
@qial
Updated form component with test submit code
f0b255b
@qial
Updated form to use javascript function correctly and fixed dialog is…
289a91e 
…sues
@qial
Fixed failure message coming through
d4dc94d
@qial
Updated submitfunction workings
cbfe6d7
@qial
Updated submitfunction to correctly handle all forms of functions and…
2bb5e16 
… objects on the window
@qial
Fixed functions inside of objects, but doesn't fail well when the obj…
74bb4e7 
…ect cant be found
@qial
Fixed functions inside nested objects in the submitfunction dialog
07ce128
@qial
Changed defaultSubmit to onSubmit, changed function not found alert t…
77057b8 
…o console.log, removed id from failure message div
@qial
Fixed some styling issues, cleaned up form dialog with hints
fd9728f
@qial
Updated onSubmit closure to better format so 'this' is carried over
5152f32
@qial
Cleaned up useless cases in the submit function loop
88ca794
@qial
Updated error messages for bad json in the form field model
75dcf2f
@qial
Added _blank target to form model docs link, and removed inline editi…
0196f01 
…ng from error paragraphs
@reusr1
poc style implementation of a data list component and a save/load han…
9c83f7b 
…dler for forms
@reusr1
Merge branch 'issues/136' of https://github.com/headwirecom/themeclea…
35849d3 
…n-flex into issues/136
@qial
Updated form samples and added sample-all with all supported inputs
ce28f34
@qial
Updated sample content to fix jcr import error
99450b8
@smcgrath0
#136 added styles to error messages and submit btn
4184cc1
@qial
Fixed Submit button text and other issues with formatting
ba6e404
@smcgrath0
#136 added transition for error message
77c84f1
@smcgrath0
#136 added submit button in all example schemas and removed in markup
6ae0a1c
@smcgrath0
Merge branch 'issues/136' of https://github.com/headwirecom/themeclea…
b44317b 
…n-flex into issues/136
@smcgrath0
#136 added styles for all inputs
f247851
@smcgrath0
#136 added button alignment and size dialog/styling
9c24c09
@smcgrath0
#136 fixed class string/fixed font on textarea/select
3862af1
@qial
updated inline settings for failure messages
e7da0a8
@qial
Added groups to the input type sample form
5dac11f
Felix Puetz added 4 commits March 29, 2021 10:18
fix: vertical/horizontal styling ...
6302994 
.. adjust renderers assignment
fix: textarea classes ...
683087c 
.. remove console.log
re-add sample-contact.json
5c4633d
add sample-all.json ...
45a6c89 
.. update examples
@flx-sta
Copy link
Collaborator Author

flx-sta commented Mar 29, 2021 •
edited
Loading

[image]

seems like once I install this PR the drop targets in the editor disappear

@reusr1
seems like this is a general issue in peregrine-cms/develop-sling12
I've created a PR for it: headwirecom/peregrine-cms#826

[image]

I took the basic example from the jsonforms.io homepage at https://jsonforms.io/ - seems it doesnt look that great (like the group is not below)

@reusr1
Yeah apparently I had a wrong version of the json-forms core causing VerticalLayout and HorizontalLayout to be ignored

@flx-sta flx-sta marked this pull request as ready for review April 1, 2021 06:48
@flx-sta flx-sta requested a review from reusr1 April 6, 2021 12:08
@flx-sta
Copy link
Collaborator Author

flx-sta commented Apr 19, 2021

@reusr1 I've added a solution for the dependency order loading (for now).
unfortunately it is not the pretties nor the most convinient but there is no other right now without having to add a new concept of loading siteJS and renderer.html stuff

@flx-sta flx-sta mentioned this pull request Apr 19, 2021
Merged
@flx-sta flx-sta requested a review from reggie7 April 23, 2021 06:29
@flx-sta flx-sta merged commit 0dbc3fd into develop-sling12 Apr 26, 2021
@flx-sta flx-sta deleted the jsonforms-for-form-component branch April 26, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reggie7 reggie7 reggie7 approved these changes

@reusr1 reusr1 reusr1 approved these changes

Assignees

@flx-sta flx-sta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flx-sta @reusr1 @reggie7 @qial @smcgrath0