maintain layer order within source #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when sublayers are toggled in the layercontrol, the last one activated comes on top. This commit maintains the order that they were originally added to the source.
AlexCortinas
added a commit
to AlexCortinas/leaflet.wms
that referenced
this pull request
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19
Layers within a source should remain in the same order when they are interacted with by client code or user. I.e. when they are added/removed with the layer control. This pull request implements this by maintaining an internal array of sublayers and ensuring they are ordered according to this list before re-sending the WMS request.
In relation to issue #19, note that this ONLY addresses the bug as originally reported: order of layers within one source. It does not (yet) address the case mentioned in later comments, concerning layers from different sources not having their order preserved.