-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close issue when all tasklists is closed #66
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
from unittest.mock import Mock, patch | ||
from unittest.mock import Mock, call, patch | ||
|
||
import pytest | ||
|
||
|
@@ -76,11 +76,33 @@ def test_handle_tasklist_with_repository_name_and_title( | |
|
||
|
||
def test_handle_tasklist_with_issue_in_task_list(event, issue, repository): | ||
issue.body = "- [x] #123" | ||
issue.body = "- [ ] #123" | ||
repository.get_issue.return_value = issue | ||
with patch("src.managers.issue.handle_issue_state") as handle_issue_state: | ||
handle_tasklist(event) | ||
handle_issue_state.assert_called_once_with(True, issue) | ||
handle_issue_state.assert_called_once_with(False, issue) | ||
repository.get_issue.assert_called_once_with(123) | ||
repository.create_issue.assert_not_called() | ||
issue.edit.assert_not_called() | ||
|
||
|
||
def test_handle_tasklist_when_not_all_tasks_are_done(event, issue, repository): | ||
issue.body = "- [x] #123\r\n- [ ] #321" | ||
repository.get_issue.return_value = issue | ||
with patch("src.managers.issue.handle_issue_state") as handle_issue_state: | ||
handle_tasklist(event) | ||
handle_issue_state.assert_has_calls([call(True, issue), call(False, issue)]) | ||
repository.get_issue.assert_has_calls([call(123), call(321)]) | ||
repository.create_issue.assert_not_called() | ||
issue.edit.assert_not_called() | ||
|
||
|
||
def test_handle_tasklist_when_all_tasks_are_done(event, issue, repository): | ||
issue.body = "- [x] #123\r\n- [x] #321" | ||
repository.get_issue.return_value = issue | ||
with patch("src.managers.issue.handle_issue_state") as handle_issue_state: | ||
handle_tasklist(event) | ||
handle_issue_state.assert_has_calls([call(True, issue), call(True, issue)]) | ||
repository.get_issue.assert_has_calls([call(123), call(321)]) | ||
repository.create_issue.assert_not_called() | ||
issue.edit.assert_called_once_with(state="closed") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make sure you add additional assertions to verify the parameters of the 'issue.edit' method call as well. This is needed to ensure that it is being invoked with expected values. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be careful with directly editing the issue state without notifying or checking permissions of the user. There might be circumstances where users would want to still have discussions after closing all tasks in the task list.