3.x/Adds OciSecretsMpMetaConfigProvider.java #7359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al API-using MicroProfile Config ConfigSource implementation, by way of a Helidon MpMetaConfigProvider Signed-off-by: Laird Nelson <[email protected]>
…eTest Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
commented
Aug 10, 2023
...ETA-INF/native-image/io.helidon.config/helidon-config-oci-secrets-mp/native-image.properties
Outdated
Show resolved
Hide resolved
…/resources/mp-meta-config.yaml Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
…xes pipeline validation failure Signed-off-by: Laird Nelson <[email protected]>
…tation Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
Signed-off-by: Laird Nelson <[email protected]>
…ing from a propertyNamesSupplier Signed-off-by: Laird Nelson <[email protected]>
ljnelson
commented
Aug 15, 2023
|
|
||
| /** | ||
| * The sole {@linkplain #supportedTypes() supported type} of this {@link OciSecretsMpMetaConfigProvider} ({@value | ||
| * #OCI_SECRETS}). |
trentjeff
reviewed
Aug 16, 2023
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>4.5.14</version> |
There was a problem hiding this comment.
versions should be defined above, or better yet under dependencies/pom.xml. Deferring to @barchetta
| <!-- Compile-scoped dependencies. --> | ||
|
|
||
| <dependency> | ||
| <groupId>io.helidon.common</groupId> |
There was a problem hiding this comment.
i don't see runtime - so i guess that is coming later...
| * Infrastructure Vault</a>. | ||
| */ | ||
| @SuppressWarnings("try") | ||
| class AbstractSecretBundleConfigSource implements AutoCloseable, ConfigSource { |
There was a problem hiding this comment.
There is no doubt in my mind that we will need to implement Polling and/or Event in order to support reloading of certificates with associated new secrets that go along with them. I'll file a tracking issue for that follow-up work. See #7323
| @SuppressWarnings("checkstyle:linelength") | ||
| static Optional<Supplier<SimpleAuthenticationDetailsProvider>> simple(Function<? super String, ? extends Optional<String>> c, | ||
| Supplier<? extends SimpleAuthenticationDetailsProviderBuilder> bs, | ||
| Function<? super SimpleAuthenticationDetailsProviderBuilder, ? extends Supplier<SimpleAuthenticationDetailsProvider>> f) { |
There was a problem hiding this comment.
This will use OciExtension from the runtime module?
I guess its too early to review this PR. Stopping here and will review when it comes out of draft.
|
Pausing in favor of #7391, per instructions |
trentjeff
changed the title
|
Closing in favor of #7555. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4238 by introducing
OciSecretsMpMetaConfigProvider.java. Reviewers may find the going easiest by looking at that file first and following it "outwards".In its current state this PR uses a provisional mechanism to acquire a
Supplier<? extendsBasicAuthenticationDetailsProvider>. I'll replace this mechanism with whatever the official recipe ends up being. For now, treat this mechanism as a black box.In its current state, the
OciSecretsMpMetaConfigProviderhas, deliberately, very few features. Properties that itsConfigSourceis supposed to respond to are indicated by a wholly-matching regular expression. No caching is performed. Nothing else fancy happens. Maybe it will later.The approach of coupling this with Helidon's MicroProfile Config-flavored meta-configuration facility follows directions from others. Module, package, and artifact names follow directions from others. This Maven module's location within the Helidon tree also follows directions from others. I hope I got the directions right.
Subsequent revisions of this PR will include full documentation as it progresses.