Maven plugin for Helidon Service Inject #9461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tomas-langer
force-pushed
the
9158-inject-maven-plugin
branch
from
4781036
to
aaf4d5f
Compare
danielkec
requested changes
Nov 22, 2024
service/inject/inject/src/main/java/io/helidon/service/inject/InjectStartupProvider.java
Outdated
Show resolved
Hide resolved
service/inject/inject/src/main/java/io/helidon/service/inject/InjectionMain.java
Show resolved
Hide resolved
...ject/maven-plugin/src/main/java/io/helidon/service/inject/maven/plugin/BindingGenerator.java
Outdated
Show resolved
Hide resolved
...ice/inject/maven-plugin/src/main/java/io/helidon/service/inject/maven/plugin/MavenFiler.java
Outdated
Show resolved
Hide resolved
| @@ -1506,6 +1506,11 @@ | |||
| <artifactId>helidon-service-inject</artifactId> | |||
| <version>${helidon.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
We need a pluginManagement in the application parent pom.
There was a problem hiding this comment.
I would prefer to leave the application updates to Helidon declarative, as this requires actual applications using it to verify it is done correctly, and that seemed like a bit bigger task.
There was a problem hiding this comment.
This plugin will be usable in 4.2.0, we should provide proper version management for it.
danielkec
previously approved these changes
Nov 27, 2024
tomas-langer
force-pushed
the
9158-inject-maven-plugin
branch
from
90f167a
to
50e0681
Compare
Moved version management for maven plugin to project root pom, moved plugin configuration there as well A fix in `AptTypeInfoFactory` where a NPE was possible.
Switch hint log level to trace in maven plugin Removed bad info log, added useful info log to maven plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven plugin that:
InjectConfigthat disables bootstrap service discovery)To see what happens, build the project with
-Ptests, and check directory:service/tests/inject/toolbox/target/generated-sources/annotations/io/helidon/service/tests/inject/toolboxSee
ApplicationMainandInjection__Bindingclasses.