Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: netty 4.1.115, grpc-java 1.65.1 #9498

Merged
merged 5 commits into from
Nov 16, 2024
Merged

3.x: netty 4.1.115, grpc-java 1.65.1 #9498

merged 5 commits into from
Nov 16, 2024

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Nov 13, 2024 •
edited
Loading

Description

  • Upgrade Netty to 4.1.115
  • Upgrade grpc-java to 1.65.1 (matches what is currently in main. See Upgrades gRPC dependencies to latest versions #9105). Required by Netty upgrade.
  • google-protobuf is already at 3.25.5 (matches what is in main)
  • Drops dependency on protobuf lite in favor of the full version which we already depended on (like main).
  • Upgrade dependency check plugin to 11.1.0

@barchetta barchetta added dependencies Pull requests that update a dependency file 3.x Issues for 3.x version branch labels Nov 13, 2024
@barchetta barchetta added this to the 3.2.11 milestone Nov 13, 2024
@barchetta barchetta self-assigned this Nov 13, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 13, 2024
@barchetta
Copy link
Member Author

barchetta commented Nov 13, 2024 •
edited
Loading

On grpc test failure:

  • Passes with Netty 4.1.110
  • Fails with 4.1.111+

Diff between 4.1.110 and 4.1.111. Note there are changes in buffer management.

@barchetta
Copy link
Member Author

Looks like we need to upgrade to https://github.com/grpc/grpc-java/releases/tag/v1.65.1. (that would match what is currently in main)

@barchetta barchetta changed the title 3.x: netty 4.1.115 3.x: netty 4.1.115, grpc-java 1.65.1 Nov 14, 2024
spericas
spericas approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta merged commit e76e4bb into helidon-io:helidon-3.x Nov 16, 2024
12 checks passed
@barchetta barchetta deleted the 3.x-netty-4.1.115 branch November 16, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spericas spericas spericas approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
3.x Issues for 3.x version branch dependencies Pull requests that update a dependency file grpc OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
None yet
Milestone
3.2.11
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @spericas