Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] update co2 scaling #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] update co2 scaling #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/hello/suripu/app/sensors/SensorViewLogic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ public class SensorViewLogic {
final List<Sensor> senseOneFiveSensors = Lists.newArrayList(senseOneSensors);
senseOneFiveSensors.addAll(
Lists.newArrayList(
// Sensor.CO2,
Sensor.TVOC, Sensor.UV, Sensor.PRESSURE
Sensor.CO2, Sensor.TVOC, Sensor.UV, Sensor.PRESSURE
));

temp.put(HardwareVersion.SENSE_ONE, senseOneSensors);
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/hello/suripu/app/sensors/scales/Co2Scale.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ public class Co2Scale extends Scale {
private static List<ScaleInterval> intervals = new ArrayList<>();
static {
intervals.add(new ScaleInterval("Ideal", "The CO2 level is just right.", 0f, 599.9f, Condition.IDEAL));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this sentence not changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follows specs here: https://docs.google.com/document/d/1eodaCELYx5T5jOPKpQUpJqib3fCxNhZ40lU8xEH13js/edit

intervals.add(new ScaleInterval("Elevated", "The CO2 level is elevated.", 600f, 1199.9f, Condition.WARNING));
intervals.add(new ScaleInterval("Unhealthy", "The CO2 level is unhealthy.", 1200f, null, Condition.ALERT));
intervals.add(new ScaleInterval("A bit stuffy", "The air is a bit stuffy.", 600f, 1199.9f, Condition.WARNING));
intervals.add(new ScaleInterval("Stuffy", "The air is stuffy.", 1200f, null, Condition.ALERT));
}
@Override
public List<ScaleInterval> intervals() {
Expand Down