Split release and source dockerfile #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
|
Thank you for the PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 77 77
Lines 11191 11191
=======================================
Hits 10277 10277
Misses 914 914
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
JuanPedroGHM
force-pushed
the
fix/1168-update-docker-image-and-documentation-on-release13x-and-main
branch
from
9826dfa
to
e046708
Compare
|
Thank you for the PR! |
…on-on-release13x-and-main
|
Thank you for the PR! |
2 tasks
…on-on-release13x-and-main
|
Thank you for the PR! |
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
…on-on-release13x-and-main
|
Thank you for the PR! |
bhagemeier
requested changes
Nov 13, 2023
|
Thank you for the PR! |
|
Thank you for the PR! |
The copy of tzdata was originally intended to be used from the root of the repository. The documentation states building docker images from the docker directory. This had to be aligned. Moreover, each RUN line in a Dockerfile represents the building of another intermediate image. This has to be taken into account when writing the files. Commands such as "cd" will not work on separate lines.
|
Thank you for the PR! |
bhagemeier
approved these changes
Nov 21, 2023
mtar
deleted the
fix/1168-update-docker-image-and-documentation-on-release13x-and-main
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original purpose: Github action runners became incapable of building the heat docker file with the nvidia container, so a solution had to be found. This remains to be fixed, but the split Dockerfile and example scripts should alleviate some of the hurdles in building/running containers for users.
Additionally, removed any specific heat version number from the documentation, scripts and Dockerfiles.
Issue/s resolved: #1168, #1254
Changes proposed:
Due Diligence
Does this change modify the behavior of other functions? If so, which?
no