Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for spack #1197

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Aug 11, 2023

This PR is intended to contain all changes that are required for introducing a spack module for Heat: in particular we need to mention this in our README and the docs

@mrfh92 mrfh92 self-assigned this Aug 11, 2023
@ghost
Copy link

ghost commented Aug 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

Thank you for the PR!

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Aug 11, 2023

See spack/spack#39394 for the corresponding PR in the spack repository

@mrfh92
Copy link
Collaborator Author

mrfh92 commented Aug 11, 2023

@ClaudiaComito @JuanPedroGHM please comment in spack/spack#39394 if you agree to be mentioned as maintainers too
then Sven can ad you to the list

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa24cc6) 91.82% compared to head (367e8c7) 91.82%.
Report is 70 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          79       79           
  Lines       11457    11457           
=======================================
  Hits        10520    10520           
  Misses        937      937           
Flag Coverage Δ
unit 91.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 4, 2023
@mrfh92
Copy link
Collaborator Author

mrfh92 commented Dec 7, 2023

TODO: add the minimal version of spack required for installing Heat once Heat receipt becomes part of the next spack release

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Thank you for the PR!

@mrfh92 mrfh92 added documentation Anything related to documentation and removed stale labels Dec 7, 2023
Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Feb 19, 2024
Copy link
Contributor

This pull request was closed because it has been inactive for 60 days since being marked as stale.

@github-actions github-actions bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to documentation stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant