Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport merged Pull Request #1333

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Conversation

mtar
Copy link
Collaborator

@mtar mtar commented Jan 30, 2024

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

This PR introduces an action workflow that allows to port merged Pull Requests to other branches. See action

replaces: #1189

Changes proposed:

  • add backport workflow using action

Type of change

workflow

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

no

@mtar mtar added the workflows label Jan 30, 2024
@ghost
Copy link

ghost commented Jan 30, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

Thank you for the PR!

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31d0752) 91.75% compared to head (953ca52) 91.84%.

❗ Current head 953ca52 differs from pull request most recent head 7c7bcb9. Consider uploading reports for the commit 7c7bcb9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
+ Coverage   91.75%   91.84%   +0.08%     
==========================================
  Files          79       79              
  Lines       11502    11464      -38     
==========================================
- Hits        10554    10529      -25     
+ Misses        948      935      -13     
Flag Coverage Δ
unit 91.84% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92
Copy link
Collaborator

mrfh92 commented Jan 31, 2024

Cool 👍

Copy link
Contributor

Thank you for the PR!

delete tick about base branch before ready for review
@mtar mtar marked this pull request as ready for review January 31, 2024 10:21
Copy link
Contributor

Thank you for the PR!

Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @mtar !

@mtar mtar merged commit b7d5a8f into main Feb 2, 2024
48 checks passed
@mtar mtar deleted the workflows/backport-merged-pull-request branch February 2, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants