-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for docker compose secrets #255
base: main
Are you sure you want to change the base?
Conversation
enables using [docker compose secrets](https://docs.docker.com/compose/use-secrets/) from arion, which includes: - [top-level `secrets` element](https://docs.docker.com/compose/compose-file/09-secrets/) defining the secrets to be used for the below two use-cases, exposing them at `/run/secrets/<secret_name>`. comes in flavors `file` vs `environment`. - run-time: [`services` top-level `secrets` element](https://docs.docker.com/compose/compose-file/05-services/#secrets) - build time: [build secrets](https://docs.docker.com/build/building/secrets/) (to be [mounted](https://docs.docker.com/build/building/secrets/#secret-mounts) in the `Dockerfile` like `RUN --mount=type=secret,id=<secret_name> ...`) unlike hercules-ci#52, i did not so far add support for their [long syntax](https://docs.docker.com/compose/compose-file/05-services/#long-syntax-4), which despite the confusing documentation appears [limited to Docker Swarm](docker/compose#9648 (comment)), in my understanding limiting its use in Arion.
to make the support for build secrets in the compose file more useful, i'm still trying to figure out how to pass those secret mounts to edit: i'm now under the impression the actual nixos config is realized at run-time, meaning for nixos containers we would not currently be able to utilize build secrets' limited secret exposure edit 2: i think we could set
|
given docker stack/swarm seems to support e.g. secrets' long-syntax (configure secret permissions/ownership) and |
…ice secrets lists
Is this stil under work? It would be extremely useful. |
@aacebedo i had not worked on this further, no |
enables using docker compose secrets from arion, which includes:
secrets
element defining the secrets to be usedfor the below two use-cases,
exposing them at
/run/secrets/<secret_name>
.comes in flavors
file
vsenvironment
.services
top-levelsecrets
elementDockerfile
likeRUN --mount=type=secret,id=<secret_name> ...
)unlike #52, i did not so far add support for their long syntax, which despite the confusing documentation appears
limited to Docker Swarm, in my understanding currently limiting its use in Arion.