Prototype of multi-agents module for nix-darwin #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avnik
force-pushed
the
avnik/darwin-multi
branch
11 times, most recently
from
b83ba41 to
4ea7a7c
Compare
aciceri
reviewed
Apr 22, 2024
|
|
||
| nix.settings.trusted-users = [ cfg.user ]; | ||
|
|
||
| system.activationScripts.preActivation.text = '' |
There was a problem hiding this comment.
I would suggest to use a different name that refers to hercules-ci for the activation script.
There was a problem hiding this comment.
preActivation is a proper name for nix-darwin (it have set of predefined names, which later substituted, I can't use arbitrary name -- https://github.com/LnL7/nix-darwin/blob/master/modules/system/activation-scripts.nix#L53 )
There was a problem hiding this comment.
Interesting...I didn't know. Their types is types.lines so they merge well if someone else sets preActivation (which was my main concern).
There was a problem hiding this comment.
Resolve it if all ok. I rebased/squashed commits
aciceri
approved these changes
Jun 28, 2024
|
Replaced by #609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effort is a bit incomplete, due lack of mac osx experience and nix-darwin knowledge.
All agents by default run from same user (I have no idea how to generate uids for each agent, as well as have no idea about
knowUsersstatements and underscored names). But also here a "handle" to assign explicit user to each agent.Some path is hardcoded (common base directory), as well as usernames.
Both criticizing and advices are welcomed