Fix (clippy) warnings in Rust generated code #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix (clippy) warnings in Rust tests Tested against rustc version 1.63.0. After this is merged and the new generator is released, additional flag `--all-targets` can be added to `cargo test` in CI. Signed-off-by: boxdot <[email protected]>
boxdot
force-pushed
the
boxdot/clippy-warnings
branch
from
5bd3abc
to
0bef56e
Compare
boxdot
changed the title
VeaaC
reviewed
Aug 22, 2022
| @@ -109,15 +109,13 @@ impl ::std::fmt::Debug for {{archive.name}} { | |||
| } | |||
|
|
|||
| impl {{archive.name}} { | |||
| #[allow(unused_imports, unused_variables)] | |||
There was a problem hiding this comment.
This is a bit less granular, though, isn't it?
What's the problem with annotating exactly the imports/variable that might be unused?
There was a problem hiding this comment.
It did not work in the first place:
683 | #[allow(unused_variables)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_var
There is no way to annotated a single import as maybe being unused.
There was a problem hiding this comment.
But annotating a single variable is possible, should we do that?
VeaaC
reviewed
Aug 22, 2022
VeaaC
reviewed
Aug 22, 2022
VeaaC
reviewed
Aug 22, 2022
VeaaC
reviewed
Aug 22, 2022
Signed-off-by: boxdot <[email protected]>
boxdot
force-pushed
the
boxdot/clippy-warnings
branch
from
214091a
to
c15ecf2
Compare
|
@boxdot btw, what's up with this one? |
Technically, I am still waiting on you review. The only one comment left, where we need to decide how to go forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix (clippy) warnings in Rust tests
Tested against rustc version 1.63.0. After this is merged and the new
generator is released, additional flag
--all-targetscan be added tocargo testin CI.