Bundle node #58
Merged
Bundle node #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
force-pushed
the
bundle-node
branch
4 times, most recently
from
00a3266
to
84fec13
Compare
| steps: | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22.x' |
There was a problem hiding this comment.
is there a specific reason for Node 22? or we can set to latest
| 'Content-Type': 'application/json', | ||
| }, | ||
| }; | ||
| const request = https.get(url, options, (response) => { |
There was a problem hiding this comment.
can we use fetch instead of https.get?
There was a problem hiding this comment.
I was concerned about using fetch because this needs to run in node v14+ and IIRC fetch was added after 14
There was a problem hiding this comment.
yes thats what I thought too, just wanted to confirm, fetch has been marked stable from 18
JessicaSachs
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.