Stop setting the LANG env var
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the buildpack would set the `LANG` env var at build and run time to the value `C.UTF-8`, to match the official Docker Python images. However, the env var should not be needed for modern Python, and so the official Docker Python images no longer set it: docker-library/python#887 docker-library/python#895 In addition, the older issues typically only affected other distros such as alpine, or environments where someone had overridden the system locale, which doesn't apply to the Heroku base images.
Malax
approved these changes
Dec 16, 2024
heroku-linguist bot
added a commit
that referenced
this pull request
Dec 18, 2024
## heroku/python ### Changed - The build now fails early if known problematic Python and pip-related env vars have been set by the user or earlier buildpacks. ([#308](#308)) - The `PIP_PYTHON` env var is now only set at build time. ([#307](#307)) ### Removed - Stopped setting the `LANG` env var. ([#306](#306)) - Stopped setting the `PYTHONHOME` env var. ([#309](#309))
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Dec 18, 2024
## heroku/python ### Changed - The build now fails early if known problematic Python and pip-related env vars have been set by the user or earlier buildpacks. ([#308](heroku/buildpacks-python#308)) - The `PIP_PYTHON` env var is now only set at build time. ([#307](heroku/buildpacks-python#307)) ### Removed - Stopped setting the `LANG` env var. ([#306](heroku/buildpacks-python#306)) - Stopped setting the `PYTHONHOME` env var. ([#309](heroku/buildpacks-python#309))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the buildpack would set the
LANGenv var at build and run time to the valueC.UTF-8, to match the official Docker Python images.However, the env var should not be needed for modern Python, and so the official Docker Python images no longer set it:
docker-library/python#887
docker-library/python#895
In addition, the older issues typically only affected other distros such as alpine, or environments where someone had overridden the system locale, which doesn't apply to the Heroku base images.
GUS-W-17443565.