Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set PIP_PYTHON at build time #307

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Dec 16, 2024

Since it's not needed at run time after #264.

GUS-W-17444427.

@edmorley edmorley self-assigned this Dec 16, 2024
@edmorley edmorley marked this pull request as ready for review December 16, 2024 17:03
@edmorley edmorley requested a review from a team as a code owner December 16, 2024 17:03
Base automatically changed from rm-lang-env-var to main December 16, 2024 17:06
Since it's not needed at run time after #264.
@edmorley edmorley force-pushed the pip-python-env-build-only branch from bf9b514 to 34c8090 Compare December 16, 2024 17:06
@edmorley edmorley enabled auto-merge (squash) December 16, 2024 17:08
@edmorley edmorley merged commit b82a2a7 into main Dec 16, 2024
7 checks passed
@edmorley edmorley deleted the pip-python-env-build-only branch December 16, 2024 17:09
heroku-linguist bot added a commit that referenced this pull request Dec 18, 2024
## heroku/python

### Changed

- The build now fails early if known problematic Python and pip-related env vars have been set by the user or earlier buildpacks. ([#308](#308))
- The `PIP_PYTHON` env var is now only set at build time. ([#307](#307))

### Removed

- Stopped setting the `LANG` env var. ([#306](#306))
- Stopped setting the `PYTHONHOME` env var. ([#309](#309))
heroku-linguist bot added a commit to heroku/cnb-builder-images that referenced this pull request Dec 18, 2024
## heroku/python

### Changed

- The build now fails early if known problematic Python and pip-related env vars have been set by the user or earlier buildpacks. ([#308](heroku/buildpacks-python#308))
- The `PIP_PYTHON` env var is now only set at build time. ([#307](heroku/buildpacks-python#307))

### Removed

- Stopped setting the `LANG` env var. ([#306](heroku/buildpacks-python#306))
- Stopped setting the `PYTHONHOME` env var. ([#309](heroku/buildpacks-python#309))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants