Switch back to using heroku/procfile from the builder in tests
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `heroku/builder:22` builder image will now only ever contain one version of the `heroku/procfile` CNB, after: heroku/buildpacks-jvm#608 heroku/buildpacks-nodejs#696 As such, we no longer need to use a manual Docker Hub URL to avoid the "multiple versions of this buildpack exist in the builder image" error.
Malax
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
heroku/builder:22builder image will now only ever contain one version of theheroku/procfileCNB, after:heroku/buildpacks-jvm#608
heroku/buildpacks-nodejs#696
As such, we no longer need to use a manual Docker Hub URL to avoid the "multiple versions of this buildpack exist in the builder image" error, and instead can use the Procfile CNB directly from the builder image.
This does mean the version is now unpinned, however, it's unlikely to cause test failures in practice, and at least we'll be testing the version of procfile actually used in the builder image (for things like the container starting tests).
GUS-W-14445053.