Include the rustup target add step in the cross-compile assistance text
#729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text In order to compile buildpacks, users need to have both the musl toolchain and the Rust target installed. If the musl toolchain is missing, we already showed help text that says what packages need to be installed. However, this help text did not mention the Rust target, meaning after installing the musl tools, users would then go on to receive another error - this time from the Rust compiler. Whilst the Rust compiler error message does suggest running the `rustup target add` command itself: - this suggestion is often lost in the noise: rust-lang/rust#117640 - it means the users has had two failed attempts in a row, which could make the experience feel open-ended/frustrating Now, the cross-compile assistance help text also suggests the `rustup target add` step, improving the UX slightly. The help texts are starting to include a fair bit of duplication, however, refactoring is covered by the separate #727. Fixes #716. GUS-W-14438920.
Malax
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to compile buildpacks, users need to have both the musl toolchain and the Rust target installed.
If the musl toolchain is missing, we already show help text that says what packages need to be installed.
However, this help text does not mention the Rust target, meaning after installing the musl tools, users will then go on to receive another error - this time from the Rust compiler.
Whilst the Rust compiler error message does suggest running the
rustup target addcommand itself:Now, the cross-compile assistance help text also suggests the
rustup target addstep, improving the UX slightly.The help texts are starting to include a fair bit of duplication, however, refactoring is covered by the separate #727.
Fixes #716.
GUS-W-14438920.