Struct Layer API

CHANGELOG.md

@@ -9,6 +9,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- `libcnb`:
+  - A new API for working with layers as been added. Check `BuildContext::cached_layer` for a starting point how to work with this API. ([#814](https://github.com/heroku/libcnb.rs/pull/814))
+
+### Changed
+
+- `libcnb`:
+  - The `Layer` trait and related types and functions have been deprecated. Please migrate to the new API. ([#814](https://github.com/heroku/libcnb.rs/pull/814))
+  - Errors related to layers have been restructured. While this is technically a breaking change, buildpacks usually don't have to be modified in practice. ([#814](https://github.com/heroku/libcnb.rs/pull/814))
+
 ### Fixed
 
 - `libcnb-data`:

examples/execd/src/main.rs

@@ -1,3 +1,7 @@
+// This example uses the older trait Layer API. The example will be updated to the newer API
+// before the next libcnb.rs release.
+#![allow(deprecated)]
+
 mod layer;
 
 use crate::layer::ExecDLayer;

libcnb/src/build.rs

@@ -6,9 +6,18 @@ use crate::data::store::Store;
 use crate::data::{
     buildpack::ComponentBuildpackDescriptor, buildpack_plan::BuildpackPlan, launch::Launch,
 };
-use crate::layer::{HandleLayerErrorOrBuildpackError, Layer, LayerData};
+use crate::layer::trait_api::handling::LayerErrorOrBuildpackError;
+use crate::layer::{
+    CachedLayerDefinition, InspectRestoredAction, IntoAction, InvalidMetadataAction, LayerRef,
+    UncachedLayerDefinition,
+};
 use crate::sbom::Sbom;
 use crate::Target;
+use libcnb_data::generic::GenericMetadata;
+use libcnb_data::layer_content_metadata::LayerTypes;
+use serde::de::DeserializeOwned;
+use serde::Serialize;
+use std::borrow::Borrow;
 use std::path::PathBuf;
 
 /// Context for the build phase execution.
@@ -24,13 +33,13 @@ pub struct BuildContext<B: Buildpack + ?Sized> {
 }
 
 impl<B: Buildpack + ?Sized> BuildContext<B> {
-    /// Handles the given [`Layer`] implementation in this context.
+    /// Handles the given [`crate::layer::Layer`] implementation in this context.
     ///
     /// It will ensure that the layer with the given name is created and/or updated accordingly and
     /// handles all errors that can occur during the process. After this method has executed, the
     /// layer will exist on disk or an error has been returned by this method.
     ///
-    /// Use the returned [`LayerData`] to access the layers metadata and environment variables for
+    /// Use the returned [`crate::layer::LayerData`] to access the layers metadata and environment variables for
     /// subsequent logic or layers.
     ///
     /// # Example:
@@ -95,18 +104,297 @@ impl<B: Buildpack + ?Sized> BuildContext<B> {
     ///     }
     /// }
     /// ```
-    pub fn handle_layer<L: Layer<Buildpack = B>>(
+    #[deprecated = "The Layer trait API was replaced by a struct based API. Use `cached_layer` and `uncached_layer`."]
+    #[allow(deprecated)]
+    pub fn handle_layer<L: crate::layer::Layer<Buildpack = B>>(
         &self,
         layer_name: LayerName,
         layer: L,
-    ) -> crate::Result<LayerData<L::Metadata>, B::Error> {
-        crate::layer::handle_layer(self, layer_name, layer).map_err(|error| match error {
-            HandleLayerErrorOrBuildpackError::HandleLayerError(e) => {
-                crate::Error::HandleLayerError(e)
+    ) -> crate::Result<crate::layer::LayerData<L::Metadata>, B::Error> {
+        crate::layer::trait_api::handling::handle_layer(self, layer_name, layer).map_err(|error| {
+            match error {
+                LayerErrorOrBuildpackError::LayerError(e) => crate::Error::LayerError(e),
+                LayerErrorOrBuildpackError::BuildpackError(e) => crate::Error::BuildpackError(e),
             }
-            HandleLayerErrorOrBuildpackError::BuildpackError(e) => crate::Error::BuildpackError(e),
         })
     }
+
+    /// Creates a cached layer, potentially re-using a previously cached version.
+    ///
+    /// Buildpack code uses this function to create a cached layer and will get back a reference to
+    /// the layer directory on disk. Intricacies of the CNB spec are automatically handled such as
+    /// the maintenance of TOML files. Buildpack code can also specify a callback for cached layer
+    /// invalidation.
+    ///
+    /// Users of this function pass in a [`CachedLayerDefinition`] that describes the desired layer
+    /// and the returned `LayerRef` can then be used to modify the layer like any other path. This
+    /// allows users to be flexible when and how the layer is modified and to abstract layer
+    /// creation away if necessary.
+    ///
+    /// # Basic Example
+    /// ```rust
+    /// # use libcnb::build::{BuildContext, BuildResult, BuildResultBuilder};
+    /// # use libcnb::detect::{DetectContext, DetectResult};
+    /// # use libcnb::generic::GenericPlatform;
+    /// # use libcnb::layer::{
+    /// #     CachedLayerDefinition, InspectRestoredAction, InvalidMetadataAction, LayerState,
+    /// # };
+    /// # use libcnb::layer_env::{LayerEnv, ModificationBehavior, Scope};
+    /// # use libcnb::Buildpack;
+    /// # use libcnb_data::generic::GenericMetadata;
+    /// # use libcnb_data::layer_name;
+    /// # use std::fs;
+    /// #
+    /// # struct ExampleBuildpack;
+    /// #
+    /// # #[derive(Debug)]
+    /// # enum ExampleBuildpackError {
+    /// #     WriteDataError(std::io::Error),
+    /// # }
+    /// #
+    /// # impl Buildpack for ExampleBuildpack {
+    /// #    type Platform = GenericPlatform;
+    /// #    type Metadata = GenericMetadata;
+    /// #    type Error = ExampleBuildpackError;
+    /// #
+    /// #    fn detect(&self, context: DetectContext<Self>) -> libcnb::Result<DetectResult, Self::Error> {
+    /// #        unimplemented!()
+    /// #    }
+    /// #
+    /// #    fn build(&self, context: BuildContext<Self>) -> libcnb::Result<BuildResult, Self::Error> {
+    /// let layer_ref = context.cached_layer(
+    ///     layer_name!("example_layer"),
+    ///     CachedLayerDefinition {
+    ///         build: false,
+    ///         launch: false,
+    ///         // Will be called if a cached version of the layer was found, but the metadata
+    ///         // could not be parsed. In this example, we instruct libcnb to always delete the
+    ///         // existing layer in such a case. But we can implement any logic here if we want.
+    ///         invalid_metadata: &|_| InvalidMetadataAction::DeleteLayer,
+    ///         // Will be called if a cached version of the layer was found. This allows us to
+    ///         // inspect the contents and metadata to decide if we want to keep the existing
+    ///         // layer or let libcnb delete the existing layer and create a new one for us.
+    ///         // This is libcnb's method to implement cache invalidations for layers.
+    ///         inspect_restored: &|_: &GenericMetadata, _| InspectRestoredAction::KeepLayer,
+    ///     },
+    /// )?;
+    ///
+    /// // At this point, a layer exists on disk. It might contain cached data or might be empty.
+    /// // Since we need to conditionally work with the layer contents based on its state, we can
+    /// // inspect the `contents` field of the layer reference to get detailed information about
+    /// // the current layer contents and the cause(s) for the state.
+    /// //
+    /// // In the majority of cases, we don't need more details beyond if it's empty or not and can
+    /// // ignore the details. This is what we do in this example. See the later example for a more
+    /// // complex situation.
+    /// match layer_ref.state {
+    ///     LayerState::Empty { .. } => {
+    ///         println!("Creating new example layer!");
+    ///
+    ///         // Modify the layer contents with regular Rust functions:
+    ///         fs::write(
+    ///             layer_ref.path().join("data.txt"),
+    ///             "Here is some example data",
+    ///         )
+    ///         .map_err(ExampleBuildpackError::WriteDataError)?;
+    ///
+    ///         // Use functions on LayerRef for common CNB specific layer modifications:
+    ///         layer_ref.replace_env(LayerEnv::new().chainable_insert(
+    ///             Scope::All,
+    ///             ModificationBehavior::Append,
+    ///             "PLANET",
+    ///             "LV-246",
+    ///         ))?;
+    ///     }
+    ///     LayerState::Restored { .. } => {
+    ///         println!("Reusing example layer from previous run!");
+    ///     }
+    /// }
+    /// #
+    /// #        BuildResultBuilder::new().build()
+    /// #    }
+    /// # }
+    /// #
+    /// # impl From<ExampleBuildpackError> for libcnb::Error<ExampleBuildpackError> {
+    /// #    fn from(value: ExampleBuildpackError) -> Self {
+    /// #        Self::BuildpackError(value)
+    /// #    }
+    /// # }
+    /// ```
+    ///
+    /// # More complex example
+    /// ```rust
+    /// # use libcnb::build::{BuildContext, BuildResult, BuildResultBuilder};
+    /// # use libcnb::detect::{DetectContext, DetectResult};
+    /// # use libcnb::generic::GenericPlatform;
+    /// # use libcnb::layer::{
+    /// #     CachedLayerDefinition, EmptyLayerCause, InspectRestoredAction, InvalidMetadataAction,
+    /// #     LayerState,
+    /// # };
+    /// # use libcnb::Buildpack;
+    /// # use libcnb_data::generic::GenericMetadata;
+    /// # use libcnb_data::layer_name;
+    /// # use serde::{Deserialize, Serialize};
+    /// # use std::fs;
+    /// #
+    /// # struct ExampleBuildpack;
+    /// #
+    /// # #[derive(Debug)]
+    /// # enum ExampleBuildpackError {
+    /// #     UnexpectedIoError(std::io::Error),
+    /// # }
+    /// #
+    /// #[derive(Deserialize, Serialize)]
+    /// struct ExampleLayerMetadata {
+    ///     lang_runtime_version: String,
+    /// }
+    ///
+    /// enum CustomCause {
+    ///     Ok,
+    ///     LegacyVersion,
+    ///     HasBrokenModule,
+    ///     MissingModulesFile,
+    /// }
+    ///
+    /// # impl Buildpack for ExampleBuildpack {
+    /// #     type Platform = GenericPlatform;
+    /// #     type Metadata = GenericMetadata;
+    /// #     type Error = ExampleBuildpackError;
+    /// #
+    /// #     fn detect(&self, _: DetectContext<Self>) -> libcnb::Result<DetectResult, Self::Error> {
+    /// #         unimplemented!()
+    /// #     }
+    /// #
+    /// fn build(&self, context: BuildContext<Self>) -> libcnb::Result<BuildResult, Self::Error> {
+    ///     let layer_ref = context.cached_layer(
+    ///         layer_name!("example_layer"),
+    ///         CachedLayerDefinition {
+    ///             build: false,
+    ///             launch: false,
+    ///             invalid_metadata: &|_| InvalidMetadataAction::DeleteLayer,
+    ///             inspect_restored: &|metadata: &ExampleLayerMetadata, layer_dir| {
+    ///                 if metadata.lang_runtime_version.starts_with("0.") {
+    ///                     Ok((
+    ///                         InspectRestoredAction::DeleteLayer,
+    ///                         CustomCause::LegacyVersion,
+    ///                     ))
+    ///                 } else {
+    ///                     let file_path = layer_dir.join("modules.txt");
+    ///
+    ///                     if file_path.is_file() {
+    ///                         // This is a fallible operation where an unexpected IO error occurs
+    ///                         // during operation. In this example, we chose not to map it to
+    ///                         // a layer action but let it automatically "bubble up". This error will
+    ///                         // end up in the regular libcnb buildpack on_error.
+    ///                         let file_contents = fs::read_to_string(&file_path)
+    ///                             .map_err(ExampleBuildpackError::UnexpectedIoError)?;
+    ///
+    ///                         if file_contents == "known-broken-0.1c" {
+    ///                             Ok((
+    ///                                 InspectRestoredAction::DeleteLayer,
+    ///                                 CustomCause::HasBrokenModule,
+    ///                             ))
+    ///                         } else {
+    ///                             Ok((InspectRestoredAction::KeepLayer, CustomCause::Ok))
+    ///                         }
+    ///                     } else {
+    ///                         Ok((
+    ///                             InspectRestoredAction::DeleteLayer,
+    ///                             CustomCause::MissingModulesFile,
+    ///                         ))
+    ///                     }
+    ///                 }
+    ///             },
+    ///         },
+    ///     )?;
+    ///
+    ///     match layer_ref.state {
+    ///         LayerState::Empty { ref cause } => {
+    ///             // Since the cause is just a regular Rust value, we can match it with regular
+    ///             // Rust syntax and be as complex or simple as we need.
+    ///             let message = match cause {
+    ///                 EmptyLayerCause::Inspect {
+    ///                     cause: CustomCause::LegacyVersion,
+    ///                 } => "Re-installing language runtime (legacy cached version)",
+    ///                 EmptyLayerCause::Inspect {
+    ///                     cause: CustomCause::HasBrokenModule | CustomCause::MissingModulesFile,
+    ///                 } => "Re-installing language runtime (broken modules detected)",
+    ///                 _ => "Installing language runtime",
+    ///             };
+    ///
+    ///             println!("{message}");
+    ///
+    ///             // Code to install the language runtime would go here
+    ///
+    ///             layer_ref.replace_metadata(ExampleLayerMetadata {
+    ///                 lang_runtime_version: String::from("1.0.0"),
+    ///             })?;
+    ///         }
+    ///         LayerState::Restored { .. } => {
+    ///             println!("Re-using cached language runtime");
+    ///         }
+    ///     }
+    ///
+    ///     BuildResultBuilder::new().build()
+    /// }
+    /// # }
+    /// #
+    /// # impl From<ExampleBuildpackError> for libcnb::Error<ExampleBuildpackError> {
+    /// #     fn from(value: ExampleBuildpackError) -> Self {
+    /// #         Self::BuildpackError(value)
+    /// #     }
+    /// # }
+    /// ```
+    pub fn cached_layer<'a, M, MA, IA, MAC, IAC>(
+        &self,
+        layer_name: impl Borrow<LayerName>,
+        layer_definition: impl Borrow<CachedLayerDefinition<'a, M, MA, IA>>,
+    ) -> crate::Result<LayerRef<B, MAC, IAC>, B::Error>
+    where
+        M: 'a + Serialize + DeserializeOwned,
+        MA: 'a + IntoAction<InvalidMetadataAction<M>, MAC, B::Error>,
+        IA: 'a + IntoAction<InspectRestoredAction, IAC, B::Error>,
+    {
+        let layer_definition = layer_definition.borrow();
+
+        crate::layer::struct_api::handling::handle_layer(
+            LayerTypes {
+                launch: layer_definition.launch,
+                build: layer_definition.build,
+                cache: true,
+            },
+            layer_definition.invalid_metadata,
+            layer_definition.inspect_restored,
+            layer_name.borrow(),
+            &self.layers_dir,
+        )
+    }
+
+    /// Creates an uncached layer.
+    ///
+    /// If the layer already exists because it was cached in a previous buildpack run, the existing
+    /// data will be deleted.
+    ///
+    /// This function is essentially the same as [`BuildContext::uncached_layer`] but simpler.
+    pub fn uncached_layer(
+        &self,
+        layer_name: impl Borrow<LayerName>,
+        layer_definition: impl Borrow<UncachedLayerDefinition>,
+    ) -> crate::Result<LayerRef<B, (), ()>, B::Error> {
+        let layer_definition = layer_definition.borrow();
+
+        crate::layer::struct_api::handling::handle_layer(
+            LayerTypes {
+                launch: layer_definition.launch,
+                build: layer_definition.build,
+                cache: false,
+            },
+            &|_| InvalidMetadataAction::DeleteLayer,
+            &|_: &GenericMetadata, _| InspectRestoredAction::DeleteLayer,
+            layer_name.borrow(),
+            &self.layers_dir,
+        )
+    }
 }
 
 /// Describes the result of the build phase.

libcnb/src/error.rs

@@ -1,5 +1,5 @@
 use crate::data::launch::ProcessTypeError;
-use crate::layer::HandleLayerError;
+use crate::layer::LayerError;
 use libcnb_common::toml_file::TomlFileError;
 use std::fmt::Debug;
 
@@ -11,8 +11,8 @@ pub type Result<T, E> = std::result::Result<T, Error<E>>;
 /// An error that occurred during buildpack execution.
 #[derive(thiserror::Error, Debug)]
 pub enum Error<E> {
-    #[error("HandleLayer error: {0}")]
-    HandleLayerError(#[from] HandleLayerError),
+    #[error("Layer error: {0}")]
+    LayerError(#[from] LayerError),
 
     #[error("Process type error: {0}")]
     ProcessTypeError(#[from] ProcessTypeError),