Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errors handling assignment example usage #139

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: errors handling assignment example usage #139

merged 1 commit into from
Feb 5, 2024

Conversation

VictorMinsky
Copy link

Current example usage won't work because of how errors.Is() operates. Creation of new error using errors.New() with the same text won't match previously created errors (errBadConnection and errBadRequest)

Test cases use correct version:

image

@Malcom1986 Malcom1986 requested a review from sgmdlt December 28, 2023 10:59
@Malcom1986
Copy link
Contributor

@sgmdlt Вань, посмотри плиз

@ola-9
Copy link
Contributor

ola-9 commented Jan 26, 2024

@sgmdlt

@sgmdlt sgmdlt merged commit 66b7d92 into hexlet-basics:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgmdlt sgmdlt Awaiting requested review from sgmdlt

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VictorMinsky @Malcom1986 @ola-9 @sgmdlt