feat: add custom unique key option #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@22dm Is this a feature that you are still willing to support? |
|
Yes, although the projects I'm working on don't use this package now, and it has been so long that I don't remember the specific details, I still think it's a useful feature. I have resolved the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Enqueue Unique Task, allow the user to customize the UniqueKey instead of using Task Payload by default, because the payload may contain things like trace IDs from upstream, and in some scenarios these tasks should still be considered the same task despite the differences in these fields.
The reason for not using task ID is that TTL is needed to avoid some workers quitting abnormally, making it impossible to continue the task.