Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Adds Ping() to client/scheduler/server #585

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

pbarnum
Copy link
Contributor

@pbarnum pbarnum commented Dec 14, 2022

No description provided.

@pbarnum
Copy link
Contributor Author

pbarnum commented Dec 14, 2022

@hibiken, this should close #445

@mdaliyan
Copy link

Right now I'm pushing a task with an empty payload and then I'm ignoring it when I consume it for the sake of health check. Exposing Ping makes it much easier and cleaner health check than my approach. Please consider increasing the priority for this PR if possible. Thank you.

@korourke9
Copy link

This would be a huge help in re-establishing connections automatically rather than manually when Redis gets a new IP. Please consider giving this some attention @hibiken

bojanz added a commit to bojanz/asynq that referenced this pull request Nov 12, 2023
@bojanz
Copy link

bojanz commented Nov 12, 2023

@hibiken What can we do to push this along? I need a client.Ping() to be able to integrate into my app's health check metrics.

@arpitflex
Copy link

We are deploying an asynq queue alongside our services in a Kubernetes cluster, and a readiness check like this would be very helpful to ensure better Pod restarts by the orchestrator. Are we looking to include this with the 0.25 release @hibiken?

scheduler.go Show resolved Hide resolved
@kamikazechaser kamikazechaser merged commit b1e1389 into hibiken:master Oct 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants