-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure task check interval #694
Add option to configure task check interval #694
Conversation
@krhubert can we merge it? Looks like PR is approved and changes are very helpful. |
@lavrd yeah, please merge it! |
I don't have rights to merge, maybe @kamikazechaser or @hibiken can help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline docs suggestion.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 68.34% 68.41% +0.07%
==========================================
Files 27 27
Lines 3829 3841 +12
==========================================
+ Hits 2617 2628 +11
- Misses 928 929 +1
Partials 284 284 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc/ @hibiken
Closes
#506
#548