Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure task check interval #694

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

krhubert
Copy link
Contributor

Closes

#506
#548

@lavrd
Copy link

lavrd commented Oct 18, 2023

@krhubert can we merge it? Looks like PR is approved and changes are very helpful.

@krhubert
Copy link
Contributor Author

@lavrd yeah, please merge it!

@lavrd
Copy link

lavrd commented Oct 18, 2023

I don't have rights to merge, maybe @kamikazechaser or @hibiken can help.

Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline docs suggestion.

server.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fde294b) 68.34% compared to head (30fd989) 68.41%.
Report is 16 commits behind head on master.

Files Patch % Lines
processor.go 94.44% 0 Missing and 1 partial ⚠️
server.go 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   68.34%   68.41%   +0.07%     
==========================================
  Files          27       27              
  Lines        3829     3841      +12     
==========================================
+ Hits         2617     2628      +11     
- Misses        928      929       +1     
  Partials      284      284              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc/ @hibiken

@hibiken hibiken merged commit fdbf54e into hibiken:master Dec 10, 2023
10 of 11 checks passed
@pior pior mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants