Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: configurable janitor interval and deletion batch size #715

Conversation

zhenqianz
Copy link
Contributor

No description provided.

@fajrifernanda
Copy link

nice, finally janitor is configurable 👍🏼

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6b98c0b) 68.37% compared to head (6ca5d1d) 68.38%.
Report is 3 commits behind head on master.

Files Patch % Lines
server.go 78.57% 2 Missing and 1 partial ⚠️
janitor.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   68.37%   68.38%           
=======================================
  Files          27       27           
  Lines        3836     3846   +10     
=======================================
+ Hits         2623     2630    +7     
- Misses        929      931    +2     
- Partials      284      285    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hibiken
Copy link
Owner

hibiken commented Sep 18, 2023

@zhenqianz Thank you for creating this PR.

Would you mind updating CHANGELOG file before we merge this?

@zhenqianz
Copy link
Contributor Author

@hibiken okay, will do

@zhenqianz Thank you for creating this PR.

Would you mind updating CHANGELOG file before we merge this?

@kamikazechaser kamikazechaser mentioned this pull request Jan 29, 2024
12 tasks
@kamikazechaser kamikazechaser merged commit d04888e into hibiken:master May 6, 2024
10 of 11 checks passed
dusty-cjh pushed a commit to dusty-cjh/asynq that referenced this pull request Jul 10, 2024
…en#715)

* feature: configurable janitor interval and deletion batch size

* warn user when they set a big number of janitor batch size

* Update CHANGELOG.md

---------

Co-authored-by: Agung Hariadi Tedja <[email protected]>
dusty-cjh pushed a commit to dusty-cjh/asynq that referenced this pull request Jul 10, 2024
…en#715)

* feature: configurable janitor interval and deletion batch size

* warn user when they set a big number of janitor batch size

* Update CHANGELOG.md

---------

Co-authored-by: Agung Hariadi Tedja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants