-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: configurable janitor interval and deletion batch size #715
feature: configurable janitor interval and deletion batch size #715
Conversation
nice, finally janitor is configurable 👍🏼 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
=======================================
Coverage 68.37% 68.38%
=======================================
Files 27 27
Lines 3836 3846 +10
=======================================
+ Hits 2623 2630 +7
- Misses 929 931 +2
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhenqianz Thank you for creating this PR. Would you mind updating CHANGELOG file before we merge this? |
@hibiken okay, will do
|
…en#715) * feature: configurable janitor interval and deletion batch size * warn user when they set a big number of janitor batch size * Update CHANGELOG.md --------- Co-authored-by: Agung Hariadi Tedja <[email protected]>
…en#715) * feature: configurable janitor interval and deletion batch size * warn user when they set a big number of janitor batch size * Update CHANGELOG.md --------- Co-authored-by: Agung Hariadi Tedja <[email protected]>
No description provided.