Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): correct panic error #758

Merged
merged 9 commits into from
May 6, 2024
Merged

feat(*): correct panic error #758

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8215412
error panic handling
linhbkhn95 Sep 21, 2022
f915368
Merge branch 'master' of github.com:linhbkhn95/asynq
linhbkhn95 Apr 24, 2023
9c59451
Merge branch 'hibiken:master' into master
linhbkhn95 Jul 30, 2023
adc5d9b
updated CHANGELOG.md file
linhbkhn95 Jul 30, 2023
4edef08
Merge branch 'hibiken:master' into master
linhbkhn95 Oct 8, 2023
8bed28b
correct msg panic error (#5)
linhbkhn95 Oct 8, 2023
e946388
Merge branch 'hibiken:master' into master
linhbkhn95 Dec 18, 2023
f6b0de5
Merge branch 'hibiken:master' into master
linhbkhn95 May 2, 2024
4cee58e
correct msg panic error
linhbkhn95 Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,21 +415,19 @@ func (p *processor) queues() []string {
func (p *processor) perform(ctx context.Context, task *Task) (err error) {
defer func() {
if x := recover(); x != nil {
errMsg := string(debug.Stack())

p.logger.Errorf("recovering from panic. See the stack trace below for details:\n%s", errMsg)
p.logger.Errorf("recovering from panic. See the stack trace below for details:\n%s", string(debug.Stack()))
_, file, line, ok := runtime.Caller(1) // skip the first frame (panic itself)
if ok && strings.Contains(file, "runtime/") {
// The panic came from the runtime, most likely due to incorrect
// map/slice usage. The parent frame should have the real trigger.
_, file, line, ok = runtime.Caller(2)
}

var errMsg string
// Include the file and line number info in the error, if runtime.Caller returned ok.
if ok {
err = fmt.Errorf("panic [%s:%d]: %v", file, line, x)
errMsg = fmt.Sprintf("panic [%s:%d]: %v", file, line, x)
} else {
err = fmt.Errorf("panic: %v", x)
errMsg = fmt.Sprintf("panic: %v", x)
}
err = &errors.PanicError{
ErrMsg: errMsg,
Expand Down
Loading