Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rate redis type assertion #791

Closed
wants to merge 3 commits into from
Closed

Conversation

gwkline
Copy link

@gwkline gwkline commented Nov 29, 2023

Attempts to resolve #790

Notably updates x to use asynq 0.24.1 and go-redis v9

@gwkline gwkline marked this pull request as draft November 29, 2023 21:27
@gwkline
Copy link
Author

gwkline commented Nov 29, 2023

Changing deps alone didn't help, think the asynq.RedisClientOpt type needs to be adjusted.

@gwkline gwkline changed the title chore: update x deps fix: rate redis type assertion Nov 29, 2023
@gwkline
Copy link
Author

gwkline commented Nov 29, 2023

Hmm that doesn't seem to work either. @kamikazechaser any idea what could be causing this?

@amaury1093
Copy link

I needed this too, so gave it a try here: #795

@gwkline gwkline closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rate.NewSemaphore: type conversion failure (MakeRedisClient error?)
2 participants