pkg/CI: Update go version directive in all modules to 1.20, update CI spec to support last 2 major releases #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit de18fe9 Author: Ken Hibino <[email protected]> Date: Sun Sep 17 19:35:33 2023 -0700 Update README about supported Go versions commit 714d62b Author: Ken Hibino <[email protected]> Date: Sun Sep 17 19:26:16 2023 -0700 Bound build to the latest two go versions
Squashed commit of the following: commit 6e3656db222a3f9347ee4806ef065a1b9b01a214 Author: Mohammed Sohail <[email protected]> Date: Thu Dec 7 11:12:41 2023 +0300 pkg(x): go version update -> 1.20 commit 2931df3 Author: Amaury <[email protected]> Date: Wed Dec 6 17:47:03 2023 +0100 fix tests commit 1122780 Author: Amaury <[email protected]> Date: Wed Dec 6 16:40:32 2023 +0100 chore: Update redis to v9 in x/go.mod
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #796 +/- ##
=======================================
Coverage 68.37% 68.37%
=======================================
Files 27 27
Lines 3836 3836
=======================================
Hits 2623 2623
Misses 929 929
Partials 284 284 ☔ View full report in Codecov by Sentry. |
* closes #759 Squashed commit of the following: commit 3d94ee14aeaf9a868dbeed4b65f90ccdda1f08d6 Author: Mohammed Sohail <[email protected]> Date: Thu Dec 7 11:49:07 2023 +0300 ci: upgrade benchstat actions, go version -> 1.21.x commit 129e225 Author: angshumukherjee100 <[email protected]> Date: Sun Oct 8 11:20:43 2023 +0530 (workflow): bump go version to 1.18 in benchstat
|
@kamikazechaser do you have merge rights? Or are we waiting on @hibiken? |
|
I do have it. But We have agreed on 2/2 for not-critical PRs. |
hibiken
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #719. See the discussion for more information.
Also aims to support new language features added after 1.14. E.g. #677.
Other info
xmodule dependencies.Test changes