-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design improvements #1299
Open
glauber-sampaio
wants to merge
3,706
commits into
hicetnunc2000:main
Choose a base branch
from
glauber-sampaio:glauber-design
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Design improvements #1299
glauber-sampaio
wants to merge
3,706
commits into
hicetnunc2000:main
from
glauber-sampaio:glauber-design
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pm_and_yarn/airgap/beacon-sdk-2.3.3 Bump @airgap/beacon-sdk from 2.3.2 to 2.3.3
support for worker-src and will fall back to child-src
…_worker_src_policies_under_child_src_for_safari_support Duplicate worker-src policies under child-src
ty for the commit, I was thinking that we could try the IBM Flex. if there are other suggestions they are welcome also. the idea for the feed is interesting but I'm unsure still on how other views are gonna look (profiles, tags). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all!
I'm a huge fan of the work you're all doing.
This was my first week at HEN and by using the platform almost every second I thought of some quick wins related the UX.
I have a background in graphic and UI design so my comments are based on work experience. But don't read it as "the right thing to do", it's mostly suggestions and recommendations to maximize the overall experience for beginners like me.
General comments
1) Grid and spacing
The platform should evoke confidence and that's why I changed the spacing to be wider, taking all the space available. This way we can bring more work per scroll as we can also showcase the variety of styles of HEN’s community on the homepage, for example.
2) The navigation bar
The question I always do about hamburger menus on large sizes: why should we hide a few items inside a hamburger icon?
The experience now makes me hit the button every time I want to edit the profile, mint and objkt or manage assets. Why don't we display those items right away? Based on those questions I proposed the menu to be completely visible including the MINT button as the main action once you're synced.
3) Typography
I don't have any problem with the current monospaced choice, but it "can be a better choice" to use the IBM Plex, as it was designed by highly experienced typographers/designers and some curvers and shapes feels sexier. More info: https://www.ibm.com/plex/
In this PR you'll find
In order to make this PR relatively small, I've updated the grid for main pages, such as Search (home), Profile and Galleries.
Main Navigation
Home page
Well, that's it. I hope this helps to improve the overall experience HEN’s community.
Let me know how this can be improved.
Best,
@Glauber.