-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Show current hDAO curation amount #1336
Open
TezzardzGoneWild
wants to merge
3,740
commits into
hicetnunc2000:main
Choose a base branch
from
TezzardzGoneWild:feature/show-current-hdao-curation-amount
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature - Show current hDAO curation amount #1336
TezzardzGoneWild
wants to merge
3,740
commits into
hicetnunc2000:main
from
TezzardzGoneWild:feature/show-current-hdao-curation-amount
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacked account shutdown for megachel
not sure about that one
…event-back-button-loop Bugfix - Prevent back button loop on Artist / Collector pages
TezzardzGoneWild
changed the title
Feature/show current hdao curation amount
Feature - Show current hDAO curation amount
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Config -> Advanced section does not currently show you the value saved for your curation making it impossible to see how much will be spent when curating without going into dev tools & local storage (or updating the value prior to each curation). Additionally, it accepts non-integer values, so you can pass in any string.
hDAO_config
from local storage when initializing the state and feed that to theInput
instead ofundefined
. This will not care if there is no value in local storage -- it will initialize it as empty in the same way it was with it being explicitly told to always useundefined
type="number"
for theInput
. This will ensure only valid values are passed in, and it will prevent it from auto-populating with invalid values that may already be there from when there were no restrictions (invalid values will be populated in the same way as the explicitundefined
). This restriction does mean the value needs to be converted.toString()
prior to being written to local storage, and... || ''
was added in to prevent errors when someone attempts to save without any changes having been made.Below are some quick screenshots to show what happens in each of the cases
When the page is loaded and there is no local storage value:
When the page is loaded and there is a valid local storage value:
When the page is loaded and there is an invalid local storage value: