fix: nil pointer on certain coldstart executions

highcard-dev · Nov 21, 2024 · 338608d · 338608d
1 parent 3051991
commit 338608d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/serve.go b/cmd/serve.go
@@ -166,7 +166,7 @@ to interact and monitor the Scroll Application`,
 							finish := coldStarter.Start(ctx)
 							executedPort := <-finish
 
-							if executedPort.FinishAfterCommand == "" {
+							if executedPort == nil || executedPort.FinishAfterCommand == "" {
 								coldStarter.Stop(executedPort.StartDelay)
 							}
 

diff --git a/internal/core/services/coldstarter/servers/udp.go b/internal/core/services/coldstarter/servers/udp.go
@@ -45,7 +45,7 @@ func (u *UDP) Start(ctx context.Context, port int, onFinish func()) error {
 			n, remoteAddr, err := u.conn.ReadFromUDP(buf)
 			if err != nil {
 				if opErr, ok := err.(*net.OpError); ok && opErr.Err.Error() == "use of closed network connection" {
-					logger.Log().Info("UDP Server stopped")
+					logger.Log().Info("UDP Server stopped", zap.Error(err))
 					return
 				}
 				logger.Log().Warn("Error reading from UDP connection", zap.Error(err))