feat: add chainhook docs api generate command
#323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @MicaiahReid! did you fix the spec manually? Asking because I'd like to augment one of the core schema in another PR. |
|
@lgalabru Yes, sadly I did do this manually. I've started looking into opening a PR to fix these two:
I think that would make the autogenerated schema correct |
MicaiahReid
changed the title
chainhook docs api generate command
MicaiahReid
commented
Jul 12, 2023
lgalabru
reviewed
Jul 12, 2023
components/chainhook-cli/Cargo.toml
Outdated
| @@ -38,9 +38,13 @@ atty = "0.2.14" | |||
| crossbeam-channel = "0.5.8" | |||
| uuid = { version = "1.3.0", features = ["v4", "fast-rng"] } | |||
| threadpool = "1.8.1" | |||
| rocket_okapi = "0.8.0-rc.3" | |||
| rocket_okapi = { version = "0.8.0-rc.3", git = "https://github.com/MicaiahReid/okapi.git", branch = "feat-chainhook-fixes"} | |||
There was a problem hiding this comment.
Could we host the fork under the hirosystems org?
There was a problem hiding this comment.
Why must you thwart my plans for github significance?
lgalabru
reviewed
Jul 12, 2023
lgalabru
reviewed
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251.
I've update
chainhook-openapi.json, and I've added thechainhook docs api generatecommand to regenerate the spec as the api changes.We should update the
chainhook-openapi.jsonas part of our deployment process eventually.Also, this introduces us using a fork of
schemarsandokapi. I've created PRs in this repo so we can hopefully use the stable version again before too long.