Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese wordings #209

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Update Chinese wordings #209

merged 5 commits into from
Nov 21, 2024

Conversation

kaon
Copy link
Collaborator

@kaon kaon commented Nov 18, 2024

From 資料一線通 to 開放數據平台

image
Reference

Summary by CodeRabbit

  • New Features

    • Updated descriptions in the app to clarify the name of the data source as "開放數據平台" (formerly known as "資料一線通").
  • Bug Fixes

    • Improved messaging in notifications regarding API issues by including the previous name of the data source for better context.
  • Documentation

    • Enhanced translation resources to reflect the updated terminology for the data source in the English locale.
  • User Interface

    • Updated labels in the Settings component to reflect the new name of the data source.

kaon added 3 commits November 18, 2024 08:56
Update 開放數據平台 from 資料一線通
Update 開放數據平台 from 資料一線通
Update 開放數據平台 from 資料一線通
Copy link

coderabbitai bot commented Nov 18, 2024

Walkthrough

The pull request includes updates to four files: public/manifest.json, public/notice.json, src/i18n/translation.js, and src/pages/Settings.tsx. The changes primarily focus on clarifying the name of a data source, transitioning from "資料一線通" to "開放數據平台" in various contexts. The updates enhance the descriptions and messages related to the data source, ensuring consistency across the application.

Changes

File Change Summary
public/manifest.json Updated the description field to clarify the data source name from "資料一線通" to "開放數據平台" (previously known as 資料一線通).
public/notice.json Modified the "content" section to include the previous name of the data source in the message. Added a newline at the end of the file.
src/i18n/translation.js Updated the translation key from "資料一線通" to "開放數據平台" for the en locale, maintaining the value as "DATA.GOV.HK".
src/pages/Settings.tsx Changed the text in a ListItem to update the label from "資料一線通" to "開放數據平台".
vite.config.ts Updated the description field in the PWA manifest to reflect the new data source name.

Possibly related PRs

  • Update translation.js #201: This PR modifies the src/i18n/translation.js file, which is also affected by the main PR, specifically in the context of translation resources. Although the changes are different, both PRs involve updates to the same file related to the terminology of the data source.

🐇 In the land of code where the data flows,
A name was changed, as everyone knows.
From "資料一線通" to "開放數據平台",
Clarity blooms like a bright spring dawn.
With messages clear, our paths align,
In the world of data, all will be fine! 🌼

Warning

Rate limit exceeded

@kaon has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 89c2c6a and b7e55fc.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 89c2c6a and b7e55fc.

📒 Files selected for processing (2)
  • src/pages/Settings.tsx (1 hunks)
  • vite.config.ts (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • src/pages/Settings.tsx
  • vite.config.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
public/notice.json (1)

Update English translations to use consistent terminology for "Open Data Platform"

The codebase shows mixed usage of terminology:

  • Chinese text consistently uses "開放數據平台" with reference to the former name "資料一線通"
  • English translations vary between "DATA.GOV.HK" and "data.gov.hk"

Locations needing updates:

  • public/notice.json: Update "data.gov.hk" to "Open Data Platform (formerly DATA.GOV.HK)"
  • public/manifest.json: Consider standardizing the English description
  • src/i18n/translation.js: Update "DATA.GOV.HK" translation key to reflect the new terminology
🔗 Analysis chain

Line range hint 8-10: Consider updating English translation for consistency

While the Chinese text has been updated to reference "開放數據平台", the English translation still uses "data.gov.hk". Consider updating the English text to align with the new terminology, possibly to "Open Data Platform (formerly DATA.GOV.HK)".

Let's check if this term is used consistently across other files:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for both Chinese and English terms across the codebase
echo "Checking for current usage patterns:"
rg -i "data\.gov\.hk|開放數據平台|資料一線通" --type json --type js

Length of output: 482

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fbbb05a and 89c2c6a.

📒 Files selected for processing (3)
  • public/manifest.json (1 hunks)
  • public/notice.json (2 hunks)
  • src/i18n/translation.js (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • public/manifest.json
🔇 Additional comments (1)
public/notice.json (1)

4-4: LGTM! Clear and well-formatted Chinese text update.

The change properly maintains context by mentioning both the new name "開放數據平台" and the previous name "資料一線通", using appropriate Chinese quotation marks 「」.

src/i18n/translation.js Show resolved Hide resolved
@kaon kaon marked this pull request as draft November 18, 2024 01:18
Update「開放數據平台」(前稱資料一線通)
@kaon kaon marked this pull request as ready for review November 18, 2024 01:20
@chunlaw chunlaw merged commit b7e55fc into hkbus:master Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants