Api gateway config #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Native Terraform resources
timja
suggested changes
Nov 7, 2019
bulk-scanning.tf
Outdated
| module "ccpay-bulkscanning-product" { | ||
| source = "[email protected]:hmcts/cnp-module-api-mgmt-product?ref=master" | ||
|
|
||
| api_mgmt_name = "core-api-mgmt-demodata" |
There was a problem hiding this comment.
Suggested change
| api_mgmt_name = "core-api-mgmt-demodata" | |
| api_mgmt_name = "core-api-mgmt-${var.env}" |
bulk-scanning.tf
Outdated
| source = "[email protected]:hmcts/cnp-module-api-mgmt-product?ref=master" | ||
|
|
||
| api_mgmt_name = "core-api-mgmt-demodata" | ||
| api_mgmt_rg = "core-infra-demodata-rg" |
There was a problem hiding this comment.
Suggested change
| api_mgmt_rg = "core-infra-demodata-rg" | |
| api_mgmt_rg = "core-infra-${var.env}" |
bulk-scanning.tf
Outdated
| module "ccpay-bulkscanning-api" { | ||
| source = "[email protected]:hmcts/cnp-module-api-mgmt-api?ref=master" | ||
|
|
||
| api_mgmt_name = "core-api-mgmt-demodata" |
There was a problem hiding this comment.
Suggested change
| api_mgmt_name = "core-api-mgmt-demodata" | |
| api_mgmt_name = "core-api-mgmt-${var.env}" |
bulk-scanning.tf
Outdated
| source = "[email protected]:hmcts/cnp-module-api-mgmt-api?ref=master" | ||
|
|
||
| api_mgmt_name = "core-api-mgmt-demodata" | ||
| api_mgmt_rg = "core-infra-demodata-rg" |
There was a problem hiding this comment.
Suggested change
| api_mgmt_rg = "core-infra-demodata-rg" | |
| api_mgmt_rg = "core-infra-${var.env}" |
bulk-scanning.tf
Outdated
| source = "[email protected]:hmcts/cnp-module-api-mgmt-api-policy?ref=master" | ||
|
|
||
| api_mgmt_name = "core-api-mgmt-demodata" | ||
| api_mgmt_rg = "core-infra-demodata-rg" |
There was a problem hiding this comment.
Suggested change
| api_mgmt_rg = "core-infra-demodata-rg" | |
| api_mgmt_rg = "core-infra-${var.env}" |
variables.tf
Outdated
| variable payments_test_certificate_thumbprints { | ||
| type = "list" | ||
| # TODO: remove default and provide environment-specific values | ||
| default = [] |
There was a problem hiding this comment.
Suggested change
| default = [] |
variables.tf
Outdated
| # thumbprint of the SSL certificate for API gateway Telephony | ||
| variable payments_test_certificate_thumbprints { | ||
| type = "list" | ||
| # TODO: remove default and provide environment-specific values |
There was a problem hiding this comment.
Suggested change
| # TODO: remove default and provide environment-specific values |
variables.tf
Outdated
| # thumbprint of the SSL certificate for API gateway Payments API | ||
| variable telephony_api_gateway_certificate_thumbprints { | ||
| type = "list" | ||
| # TODO: remove default and provide environment-specific values |
There was a problem hiding this comment.
Suggested change
| # TODO: remove default and provide environment-specific values |
variables.tf
Outdated
| } | ||
|
|
||
| # thumbprint of the SSL certificate for API gateway Payments API | ||
| variable bulkscanning_api_gateway_certificate_thumbprints { | ||
| type = "list" | ||
| # TODO: remove default and provide environment-specific values | ||
| default = [] |
There was a problem hiding this comment.
Suggested change
| default = [] |
variables.tf
Outdated
| } | ||
|
|
||
| # thumbprint of the SSL certificate for API gateway Payments API | ||
| variable bulkscanning_api_gateway_certificate_thumbprints { | ||
| type = "list" | ||
| # TODO: remove default and provide environment-specific values |
There was a problem hiding this comment.
Suggested change
| # TODO: remove default and provide environment-specific values |
timja
suggested changes
Nov 7, 2019
timja
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PAY-2550
https://tools.hmcts.net/jira/browse/PAY-2449
Change description
Moving all api configuration for fee & pay team into https://github.com/hmcts/ccpay-payment-api-gateway
Reconfiguring api gateway configuration using native terraform resources
Does this PR introduce a breaking change? (check one with "x")