DTSCCI-000 unit test for extended caseType (#5103)

* DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType * DTSCCI-000 unit test for extended caseType
hmcts · Nov 25, 2024 · d13aea7 · d13aea7
1 parent d0c76bb
commit d13aea7
Show file tree

Hide file tree

Showing 22 changed files with 58 additions and 26 deletions.
diff --git a/ccd-definition/AuthorisationCaseEvent/AuthorisationCaseEventCaseProg-minti-nonprod.json b/ccd-definition/AuthorisationCaseEvent/AuthorisationCaseEventCaseProg-minti-nonprod.json
@@ -24,7 +24,7 @@
     ]
   },
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "CaseEventID": "CONFIRM_LISTING_COMPLETED",
     "AccessControl": [
       {

diff --git a/ccd-definition/AuthorisationCaseField/AuthorisationCaseField-MINTI-nonprod.json b/ccd-definition/AuthorisationCaseField/AuthorisationCaseField-MINTI-nonprod.json
@@ -365,7 +365,7 @@
     ]
   },
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "CaseFieldID": "confirmListingTickBox",
     "AccessControl": [
       {

diff --git a/ccd-definition/AuthorisationCaseField/AuthorisationCaseFieldGAspec-R2-CUI-nonprod.json b/ccd-definition/AuthorisationCaseField/AuthorisationCaseFieldGAspec-R2-CUI-nonprod.json
@@ -557,7 +557,7 @@
     ]
   },
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "CaseFieldID": "gaAddlDocClaimant",
     "AccessControl": [
       {
@@ -569,7 +569,7 @@
     ]
   },
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "CaseFieldID": "gaAddlDocRespondentSol",
     "AccessControl": [
       {

diff --git a/ccd-definition/CaseEvent/User/UserEventsCaseProg-MINTI-nonprod.json b/ccd-definition/CaseEvent/User/UserEventsCaseProg-MINTI-nonprod.json
@@ -98,7 +98,7 @@
     "ShowEventNotes": "N"
   },
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "ID": "CONFIRM_LISTING_COMPLETED",
     "Name": "Confirm Listing",
     "Description": "Confirm Listing",

diff --git a/ccd-definition/CaseEventToFields/ConfirmListing-MINTI-nonprod.json b/ccd-definition/CaseEventToFields/ConfirmListing-MINTI-nonprod.json
@@ -1,6 +1,6 @@
 [
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "CaseEventID": "CONFIRM_LISTING_COMPLETED",
     "CaseFieldID": "confirmListingTickBox",
     "PageDisplayOrder": 1,

diff --git a/ccd-definition/CaseField/CaseField-MINTI-nonprod.json b/ccd-definition/CaseField/CaseField-MINTI-nonprod.json
@@ -186,7 +186,7 @@
     "Searchable": "N"
   },
   {
-    "CaseTypeID": "CIVIL",
+    "CaseTypeID": "CIVIL${CCD_DEF_VERSION}",
     "ID": "confirmListingTickBox",
     "Label": " ",
     "FieldType": "MultiSelectList",

diff --git a/e2e/tests/unit/definitions/AuthorisationCaseEvent.test.js b/e2e/tests/unit/definitions/AuthorisationCaseEvent.test.js
@@ -9,7 +9,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.CaseEventID).to.be.a('string').and.satisfy(isNotLongerThan(MEDIUM_STRING));
   expect(row.AccessControl).to.not.be.null;

diff --git a/e2e/tests/unit/definitions/AuthorisationCaseField.test.js b/e2e/tests/unit/definitions/AuthorisationCaseField.test.js
@@ -6,20 +6,29 @@ const dataProvider = require('../utils/dataProvider');
 
 const assertFieldExists = createAssertExists('Field');
 
+function assertFieldDefinitionIsValid(row) {
+  expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
+  });
+}
+
 dataProvider.exclusions.forEach((value, key) =>  {
   describe('AuthorisationCaseField'.concat(': ', key, ' config'), () => {
     context('should :', () => {
       let authorisationCaseFieldConfig = [];
       let caseFieldConfig = [];
       let errors = [];
+      let uniqResult = [];
 
       before(() => {
         authorisationCaseFieldConfig = dataProvider.getConfig('../../../../ccd-definition/AuthorisationCaseField', key);
         caseFieldConfig = dataProvider.getConfig('../../../../ccd-definition/CaseField', key);
+        uniqResult = uniqWith(authorisationCaseFieldConfig, isFieldDuplicated('CaseFieldID'));
       });
 
+
+
       it('contain a unique case field ID, case type ID and role (no duplicates)', () => {
-        const uniqResult = uniqWith(authorisationCaseFieldConfig, isFieldDuplicated('CaseFieldID'));
         try {
           expect(uniqResult).to.eql(authorisationCaseFieldConfig);
         } catch (error) {
@@ -37,6 +46,10 @@ dataProvider.exclusions.forEach((value, key) =>  {
       it('use existing fields', () => {
         assertFieldExists(authorisationCaseFieldConfig, caseFieldConfig);
       });
+
+      it('should have only valid definitions', () => {
+         uniqResult.forEach(assertFieldDefinitionIsValid);
+      });
     });
   });
 });
diff --git a/e2e/tests/unit/definitions/AuthorisationCaseState.test.js b/e2e/tests/unit/definitions/AuthorisationCaseState.test.js
@@ -6,20 +6,27 @@ const dataProvider = require('../utils/dataProvider');
 
 const assertStateExists = createAssertExists('State');
 
+function assertFieldDefinitionIsValid(row) {
+  expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
+  });
+}
+
 dataProvider.exclusions.forEach((value, key) =>  {
   describe('AuthorisationCaseState'.concat(': ', key, ' config'), () => {
     context('definitions:', () => {
       let authorisationCaseState = [];
       let stateConfig = [];
       let errors = [];
+      let uniqResult = [];
 
       before(() => {
         authorisationCaseState = dataProvider.getConfig('../../../../ccd-definition/AuthorisationCaseState', key);
         stateConfig = dataProvider.ccdData.State;
+        uniqResult = uniqWith(authorisationCaseState, isFieldDuplicated('CaseStateID'));
       });
 
       it('should contain a unique case state, case type ID and role (no duplicates) for nonprod files', () => {
-        const uniqResult = uniqWith(authorisationCaseState, isFieldDuplicated('CaseStateID'));
         try {
           expect(uniqResult).to.eql(authorisationCaseState);
         } catch (error) {
@@ -38,6 +45,10 @@ dataProvider.exclusions.forEach((value, key) =>  {
         assertStateExists(authorisationCaseState, stateConfig);
       });
 
+        it('should have only valid definitions', () => {
+          uniqResult.forEach(assertFieldDefinitionIsValid);
+        });
+
       context('Solicitor has valid permissions', () => {
         it('CRU permissions for all states', () => {
           authorisationCaseState.forEach(authState => {

diff --git a/e2e/tests/unit/definitions/AuthorisationCaseType.test.js b/e2e/tests/unit/definitions/AuthorisationCaseType.test.js
@@ -5,7 +5,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.UserRoles).to.not.be.null;
   expect(row.AccessControl).to.not.be.null;

diff --git a/e2e/tests/unit/definitions/CaseEvent.test.js b/e2e/tests/unit/definitions/CaseEvent.test.js
@@ -11,7 +11,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertEventDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.ID).to.be.a('string').and.satisfy(isNotLongerThan(MEDIUM_STRING));
   expect(row.Name).to.be.a('string').and.satisfy(isNotLongerThan(SHORT_STRING));

diff --git a/e2e/tests/unit/definitions/CaseEventToComplexTypes.test.js b/e2e/tests/unit/definitions/CaseEventToComplexTypes.test.js
@@ -9,10 +9,6 @@ const {
 const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
-  // todo type not populated
-  // expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-  //   return v.startsWith('CIVIL');
-  // });
   const errors = [];
   if (row.length > 0) {
         row.forEach(elem => {

diff --git a/e2e/tests/unit/definitions/CaseEventToFields.test.js b/e2e/tests/unit/definitions/CaseEventToFields.test.js
@@ -3,6 +3,12 @@ const { find, uniqWith } = require('lodash');
 const { isPositiveNumber, whenPopulated, isCaseEventToFieldDuplicated } = require('../utils/utils');
 const dataProvider = require('../utils/dataProvider');
 
+function assertFieldDefinitionIsValid(row) {
+  expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
+  });
+}
+
 function assertHasOnlyValidEventIds(caseEventToFieldsFile, caseEventFile) {
   const errors = [];
   caseEventToFieldsFile.forEach(caseEventToFieldsEntry => {
@@ -60,11 +66,13 @@ dataProvider.exclusions.forEach((value, key) =>  {
       let caseEventConfig = [];
       let caseFieldConfig = [];
       let errors = [];
+      let uniqResult = [];
 
       before(() => {
         caseEventToFieldConfig = dataProvider.getConfig('../../../../ccd-definition/CaseEventToFields', key);
         caseEventConfig = dataProvider.getConfig('../../../../ccd-definition/CaseEvent', key);
         caseFieldConfig = dataProvider.getConfig('../../../../ccd-definition/CaseField', key);
+        uniqResult = uniqWith(caseEventToFieldConfig, isCaseEventToFieldDuplicated('CaseFieldID'));
       });
       it('contain valid event IDs', () => {
         assertHasOnlyValidEventIds(caseEventToFieldConfig, caseEventConfig);
@@ -75,7 +83,7 @@ dataProvider.exclusions.forEach((value, key) =>  {
       });
 
       it('not contain duplicate field IDs', () => {
-        const uniqResult = uniqWith(caseEventToFieldConfig, isCaseEventToFieldDuplicated('CaseFieldID'));
+
         try {
           expect(uniqResult).to.eql(caseEventToFieldConfig);
         } catch (error) {
@@ -90,6 +98,10 @@ dataProvider.exclusions.forEach((value, key) =>  {
         }
       });
 
+      it('should have only valid definitions', () => {
+        uniqResult.forEach(assertFieldDefinitionIsValid);
+      });
+
       it('contain valid order fields', () => {
         caseEventToFieldConfig.forEach(row => {
           assertPageFieldDisplayOrder(row);

diff --git a/e2e/tests/unit/definitions/CaseField.test.js b/e2e/tests/unit/definitions/CaseField.test.js
@@ -10,7 +10,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.ID).to.be.a('string').and.satisfy(isNotLongerThan(MEDIUM_STRING));
   expect(row.Label).to.be.a('string').and.satisfy(isNotEmpty());

diff --git a/e2e/tests/unit/definitions/CaseRoles.test.js b/e2e/tests/unit/definitions/CaseRoles.test.js
@@ -10,7 +10,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.ID).to.be.a('string').and.satisfy(isNotLongerThan(MEDIUM_STRING));
   if (row.Name) {

diff --git a/e2e/tests/unit/definitions/CaseType.test.js b/e2e/tests/unit/definitions/CaseType.test.js
@@ -8,7 +8,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.ID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.SecurityClassification).to.eq('Public');
   expect(row.Name).to.be.a('string').and.satisfy(isNotEmpty());

diff --git a/e2e/tests/unit/definitions/CaseTypeTab.test.js b/e2e/tests/unit/definitions/CaseTypeTab.test.js
@@ -9,7 +9,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.CaseFieldID).to.be.a('string').and.satisfy(isNotLongerThan(MEDIUM_STRING));
   // todo this isn't always populated

diff --git a/e2e/tests/unit/definitions/RoleToAccessProfiles.test.js b/e2e/tests/unit/definitions/RoleToAccessProfiles.test.js
@@ -8,7 +8,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.RoleName).to.be.a('string').and.satisfy(isNotEmpty());
   expect(row.AccessProfiles).to.be.a('string').and.satisfy(isNotEmpty());

diff --git a/e2e/tests/unit/definitions/SearchInputFields.test.js b/e2e/tests/unit/definitions/SearchInputFields.test.js
@@ -8,7 +8,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.CaseFieldID).to.be.a('string').and.satisfy(isNotEmpty());
   expect(row.Label).to.be.a('string').and.satisfy(isNotEmpty());

diff --git a/e2e/tests/unit/definitions/SearchResultFields.test.js b/e2e/tests/unit/definitions/SearchResultFields.test.js
@@ -8,7 +8,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.CaseFieldID).to.be.a('string').and.satisfy(isNotEmpty());
   expect(row.Label).to.be.a('string').and.satisfy(isNotEmpty());

diff --git a/e2e/tests/unit/definitions/WorkBasketInputFields.test.js b/e2e/tests/unit/definitions/WorkBasketInputFields.test.js
@@ -8,7 +8,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.CaseFieldID).to.be.a('string').and.satisfy(isNotEmpty());
   expect(row.Label).to.be.a('string').and.satisfy(isNotEmpty());

diff --git a/e2e/tests/unit/definitions/WorkBasketResultFields.test.js b/e2e/tests/unit/definitions/WorkBasketResultFields.test.js
@@ -8,7 +8,7 @@ const dataProvider = require('../utils/dataProvider');
 
 function assertFieldDefinitionIsValid(row) {
   expect(row.CaseTypeID).to.be.a('string').and.satisfy(v => {
-    return v.startsWith('CIVIL');
+    return v.startsWith('CIVIL${CCD_DEF_VERSION}');
   });
   expect(row.CaseFieldID).to.be.a('string').and.satisfy(isNotEmpty());
   expect(row.Label).to.be.a('string').and.satisfy(isNotEmpty());