Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIV-10907 - Claimant LiP notification at Hearing Scheduled #3371

Merged
merged 19 commits into from
Dec 2, 2023

Conversation

m-meulendijks-v1
Copy link
Contributor

@m-meulendijks-v1 m-meulendijks-v1 commented Oct 9, 2023

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/CIV-10907

Change description

Allow for notifications to be sent to claimant LiP.
Ignacio had done part of the work in another ticket before claimant LiP was available - I had to make some updates to make it work.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@m-meulendijks-v1 m-meulendijks-v1 requested a review from a team as a code owner October 9, 2023 15:07
dharmendrak
dharmendrak previously approved these changes Oct 10, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot removed the stale label Nov 1, 2023
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview November 3, 2023 11:14 Abandoned
Copy link

github-actions bot commented Nov 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dharmendrak
dharmendrak previously approved these changes Nov 21, 2023
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview November 22, 2023 10:15 Abandoned
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@hmcts-jenkins-a-to-c
Copy link
Contributor

Plan Result

⚠️ Resource Deletion will happen ⚠️

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 1 to change, 3 to destroy.
  • Update
    • module.key-vault.azurerm_monitor_diagnostic_setting.kv-ds
  • Delete
    • azurerm_key_vault_secret.civil_db_host__v15_secret
    • azurerm_key_vault_secret.civil_db_password__v15_secret
    • azurerm_key_vault_secret.civil_db_username__v15_secret
Change Result (Click me)
  # data.azurerm_user_assigned_identity.app_mi will be read during apply
  # (depends on a resource or a module with changes pending)
 <= data "azurerm_user_assigned_identity" "app_mi" {
      + client_id           = (known after apply)
      + id                  = (known after apply)
      + location            = (known after apply)
      + name                = "civil-aat-mi"
      + principal_id        = (known after apply)
      + resource_group_name = "managed-identities-aat-rg"
      + tags                = (known after apply)
      + tenant_id           = (known after apply)
    }

  # azurerm_key_vault_secret.civil_db_host__v15_secret will be destroyed
  # (because azurerm_key_vault_secret.civil_db_host__v15_secret is not in configuration)
  - resource "azurerm_key_vault_secret" "civil_db_host__v15_secret" {
      - content_type            = "secret" -> null
      - id                      = "https://civil-aat.vault.azure.net/secrets/cmc-db-host-v15/9d555b96c91c4351b1e6e2d7b425a0c4" -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat" -> null
      - name                    = "cmc-db-host-v15" -> null
      - resource_id             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/secrets/cmc-db-host-v15/versions/9d555b96c91c4351b1e6e2d7b425a0c4" -> null
      - resource_versionless_id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/secrets/cmc-db-host-v15" -> null
      - tags                    = {
          - "application"         = "civil"
          - "autoShutdown"        = "true"
          - "builtFrom"           = "https://github.com/HMCTS/civil-service.git"
          - "businessArea"        = "CFT"
          - "contactSlackChannel" = "#civil_contact"
          - "environment"         = "staging"
          - "managedBy"           = "Civil"
          - "source"              = "Vault cmc-aat"
        } -> null
      - value                   = (sensitive value) -> null
      - version                 = "9d555b96c91c4351b1e6e2d7b425a0c4" -> null
      - versionless_id          = "https://civil-aat.vault.azure.net/secrets/cmc-db-host-v15" -> null
    }

  # azurerm_key_vault_secret.civil_db_password__v15_secret will be destroyed
  # (because azurerm_key_vault_secret.civil_db_password__v15_secret is not in configuration)
  - resource "azurerm_key_vault_secret" "civil_db_password__v15_secret" {
      - content_type            = "secret" -> null
      - id                      = "https://civil-aat.vault.azure.net/secrets/cmc-db-password-v15/30367cae1cc048f99cdb16a4259eb9f8" -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat" -> null
      - name                    = "cmc-db-password-v15" -> null
      - resource_id             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/secrets/cmc-db-password-v15/versions/30367cae1cc048f99cdb16a4259eb9f8" -> null
      - resource_versionless_id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/secrets/cmc-db-password-v15" -> null
      - tags                    = {
          - "application"         = "civil"
          - "autoShutdown"        = "true"
          - "builtFrom"           = "https://github.com/HMCTS/civil-service.git"
          - "businessArea"        = "CFT"
          - "contactSlackChannel" = "#civil_contact"
          - "environment"         = "staging"
          - "managedBy"           = "Civil"
          - "source"              = "Vault cmc-aat"
        } -> null
      - value                   = (sensitive value) -> null
      - version                 = "30367cae1cc048f99cdb16a4259eb9f8" -> null
      - versionless_id          = "https://civil-aat.vault.azure.net/secrets/cmc-db-password-v15" -> null
    }

  # azurerm_key_vault_secret.civil_db_username__v15_secret will be destroyed
  # (because azurerm_key_vault_secret.civil_db_username__v15_secret is not in configuration)
  - resource "azurerm_key_vault_secret" "civil_db_username__v15_secret" {
      - content_type            = "secret" -> null
      - id                      = "https://civil-aat.vault.azure.net/secrets/cmc-db-username-v15/a0a62840d5d74e79af99eb3529606b18" -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat" -> null
      - name                    = "cmc-db-username-v15" -> null
      - resource_id             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/secrets/cmc-db-username-v15/versions/a0a62840d5d74e79af99eb3529606b18" -> null
      - resource_versionless_id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat/secrets/cmc-db-username-v15" -> null
      - tags                    = {
          - "application"         = "civil"
          - "autoShutdown"        = "true"
          - "builtFrom"           = "https://github.com/HMCTS/civil-service.git"
          - "businessArea"        = "CFT"
          - "contactSlackChannel" = "#civil_contact"
          - "environment"         = "staging"
          - "managedBy"           = "Civil"
          - "source"              = "Vault cmc-aat"
        } -> null
      - value                   = (sensitive value) -> null
      - version                 = "a0a62840d5d74e79af99eb3529606b18" -> null
      - versionless_id          = "https://civil-aat.vault.azure.net/secrets/cmc-db-username-v15" -> null
    }

  # module.key-vault.azurerm_monitor_diagnostic_setting.kv-ds will be updated in-place
  ~ resource "azurerm_monitor_diagnostic_setting" "kv-ds" {
        id                             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/civil-service-aat/providers/Microsoft.KeyVault/vaults/civil-aat|civil-aat"
        name                           = "civil-aat"
        # (3 unchanged attributes hidden)

      - metric {
          - category = "AllMetrics" -> null
          - enabled  = false -> null

          - retention_policy {
              - days    = 0 -> null
              - enabled = false -> null
            }
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 3 to destroy.

# Conflicts:
#	src/test/java/uk/gov/hmcts/reform/civil/handler/callback/camunda/notification/CreateSDOApplicantsNotificationHandlerTest.java
@github-actions github-actions bot removed the stale label Dec 1, 2023
@dharmendrak dharmendrak merged commit 1b2762f into master Dec 2, 2023
5 checks passed
@dharmendrak dharmendrak deleted the feat/CIV-10907 branch December 2, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants