Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIV-11381 hearing method section missing from order documents #3544

Merged
merged 12 commits into from
Nov 16, 2023
Merged

CIV-11381 hearing method section missing from order documents #3544

merged 12 commits into from
Nov 16, 2023

Conversation

MMNycz
Copy link
Contributor

@MMNycz MMNycz commented Nov 8, 2023

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

remove mid callback event validateInputValue and move that function to generateSDOOrder callback.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@MMNycz MMNycz requested a review from a team as a code owner November 8, 2023 14:50
asthamalviya
asthamalviya previously approved these changes Nov 9, 2023
View reviewed changes
@UshaPanneerselvam1 UshaPanneerselvam1 self-requested a review November 9, 2023 10:59
@asthamalviya asthamalviya dismissed stale reviews from UshaPanneerselvam1 and themself via d52d328 November 9, 2023 16:27
@asthamalviya asthamalviya merged commit 2375129 into master Nov 16, 2023
3 of 4 checks passed
@asthamalviya asthamalviya deleted the CIV-11381-Hearing-method-section-missing-from-order-documents branch November 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UshaPanneerselvam1 UshaPanneerselvam1 UshaPanneerselvam1 approved these changes

@asthamalviya asthamalviya asthamalviya approved these changes

@sabahirfan sabahirfan Awaiting requested review from sabahirfan sabahirfan is a code owner automatically assigned from hmcts/civil-admins

@sankhajuria sankhajuria Awaiting requested review from sankhajuria sankhajuria is a code owner automatically assigned from hmcts/civil-admins

Assignees
No one assigned
Labels
ns:civil prd:civil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MMNycz @asthamalviya @UshaPanneerselvam1 @mfallonhmcts @kdaHMCTS