CIV-16292 Defendant Lip Dashboard Notification-discontinued #5925
+242
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlynkhaw
reviewed
Dec 17, 2024
| * Add notification template | ||
| */ | ||
| INSERT INTO dbs.dashboard_notifications_templates ( template_name, title_En, title_Cy, description_En, description_Cy | ||
| , notification_role) |
There was a problem hiding this comment.
being a bit nitpicky but could we have this comma on the previous line?
There was a problem hiding this comment.
it's a script alignment
There was a problem hiding this comment.
can the comma not be put up on the previous line without error?
or description_Cy be brought down to line 13?
sherlynkhaw
reviewed
Dec 17, 2024
| /** | ||
| * Add notification template | ||
| */ | ||
| INSERT INTO dbs.dashboard_notifications_templates ( template_name, title_En, title_Cy, description_En, description_Cy |
There was a problem hiding this comment.
remove space before template_name
There was a problem hiding this comment.
it's a script alignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-16292
Change description
Does this PR introduce a breaking change? (check one with "x")