Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dfr 2689 auto date pension sharing annex #1944
base: master
Are you sure you want to change the base?
Dfr 2689 auto date pension sharing annex #1944
Changes from 68 commits
7094b06
7e48f09
260d15e
ea72947
0e7ded6
cfa1714
40dbf6d
8932c5c
ddf98be
841ed33
3c369cd
d4d0b6c
0f9dc9a
56b9a35
7a2069d
e0e1adb
12a7ce9
845f86a
4da16c1
3f7a4e0
56e4d04
9599a67
2b35f08
9f091cd
da5c505
8cee1be
eb6df0d
d081922
984e65c
80a6497
e5fe041
4e212f9
5bcb9fd
994305a
bb84bdb
9ff5d3c
2cfdc3f
af21e72
3ddc316
e272586
f16bb5f
de1d712
4d4429d
415f63f
c24ccb9
7f7121a
c948001
44a7742
c63fefa
f2a0d50
0996972
da14197
02b5ffc
a88295b
0e38166
9ded039
7265355
d5cc76b
2681d54
e4d9837
9c9c924
89bc764
1c3564b
f1c78ad
7b7aa5a
1cb6bdf
1b08006
cca4045
eb40926
eeb49a2
786b9c6
044c8de
7af8874
9a03e33
7e0eb32
e7b0fc6
182e573
5961746
3e4fd79
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a test needed/updated for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like textBox.getDefaultAppearance() returns a string. So you could try isBlank rather than the null and empty check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd pass case id in, so I could include in the exception. Just slightly easier for support :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New function getApprovalDate has been added to this handler. That can either take caseData with a LocalDate or String and responds with a null or OK string. Given that, suggest a test.