Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFR-3332 judge approve orders starting page #1956

Open
wants to merge 103 commits into
base: master
Choose a base branch
from
Open

DFR-3332 judge approve orders starting page #1956

wants to merge 103 commits into from

Conversation

so99y
Copy link
Contributor

@so99y so99y commented Nov 8, 2024 •
edited
Loading

Jira link

See DFR-3332

Change description

Judge Approve Orders - starting page

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

hamzahtahirhmcts and others added 30 commits November 4, 2024 13:03
@hamzahtahirhmcts
initial setup attempt
2550a69
@hamzahtahirhmcts
Add AboutToStartHandler for judge approve orders event
c826b7a
@hamzahtahirhmcts
Add event to EventType
01ec3f1
@hamzahtahirhmcts
optimise imports
efadc19
@hamzahtahirhmcts
remove dynamicList
a62ffba
Merge branch 'master' into DFR-3332-Judge-Approve-Orders---starting-page
9838fae
lower case
b7fa5d0
Merge branch 'master' into DFR-3332-Judge-Approve-Orders---starting-page
d7f8116
renaming package
b33b3e7
package rename
593976c
@hamzahtahirhmcts
Create dynamicList for selecting a hearing to review
0ac73ea
Data structure for capturing judge’s input
3097807
add TODO comment
1556fdd
checkstyle
b1e3125
remove a blank line.
eccc0b1
Remove an unused property
afb1112
@hamzahtahirhmcts
Add comment for sorting
79e858d
remove mocked data.
3f7daf9
@hamzahtahirhmcts
no orders for review error message
665235d
@hamzahtahirhmcts
Merge remote-tracking branch 'origin/DFR-3332-Judge-Approve-Orders---…
5024e9a 
…starting-page' into DFR-3332-Judge-Approve-Orders---starting-page
add utility methods
6422a9b
Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' of githu…
2f5e83e 
…b.com:hmcts/finrem-case-orchestration-service into DFR-3332-Judge-Approve-Orders---starting-page
Due to getDraftOrdersReviewCollection() changed to return empty list …
14b5040 
…if null.
@hamzahtahirhmcts
use ObjectUtils.isEmpty
0127d8b
@hamzahtahirhmcts
Add unit tests
62016f8
@hamzahtahirhmcts
Merge remote-tracking branch 'origin/DFR-3332-Judge-Approve-Orders---…
2325fff 
…starting-page' into DFR-3332-Judge-Approve-Orders---starting-page

# Conflicts:
#	src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/handler/approvedraftorders/ApproveDraftOrdersAboutToStartHandler.java
add JsonIgnore to a getter property
0a027f4
Making use getHearingId to identify the hearing selected.
99f8f43
Merge branch 'DFR-3332-Judge-Approve-Orders---starting-page' of githu…
08249f2 
…b.com:hmcts/finrem-case-orchestration-service into DFR-3332-Judge-Approve-Orders---starting-page
Fix test case
366728c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzahtahirhmcts hamzahtahirhmcts hamzahtahirhmcts left review comments

@jthmcts jthmcts jthmcts left review comments

@ptrelease ptrelease Awaiting requested review from ptrelease

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enable_keep_helm ns:financial-remedy prd:finrem rel:finrem-cos-pr-1956 use-defs-pr-2111
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@so99y @ptrelease @jthmcts @hamzahtahirhmcts