Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow port-forwarding in non-prod #5869

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Allow port-forwarding in non-prod #5869

merged 2 commits into from
Dec 12, 2024

Conversation

danlysiak
Copy link
Member

@danlysiak danlysiak commented Dec 12, 2024 •
edited by github-actions bot
Loading

Change description

Copying from CNP - https://github.com/hmcts/cnp-flux-config/blob/d18a9c4558b4fc52f372e9608eb8b66bca5232de/apps/rbac/nonprod-role.yaml#L19-L21

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

🤖AEP PR SUMMARY🤖

  • Updated nonprod-role.yaml
  • Added permission to create pods/portforward
  • Updated the rules for pod/exec to include the ability to create pods/portforward as well

@danlysiak danlysiak requested a review from a team as a code owner December 12, 2024 14:35
@danlysiak danlysiak enabled auto-merge (squash) December 12, 2024 14:53
@danlysiak danlysiak merged commit 8743528 into master Dec 12, 2024
18 checks passed
@danlysiak danlysiak deleted the danlysiak-patch-3 branch December 12, 2024 15:00
@danlysiak danlysiak mentioned this pull request Dec 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endakelly endakelly endakelly approved these changes

@NickAzureDevops NickAzureDevops Awaiting requested review from NickAzureDevops NickAzureDevops is a code owner automatically assigned from hmcts/platform-operations

@ozzyib ozzyib Awaiting requested review from ozzyib ozzyib is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danlysiak @endakelly