Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment issue during scrolling #142

Open
fbertone opened this issue Oct 13, 2021 · 3 comments
Open

alignment issue during scrolling #142

fbertone opened this issue Oct 13, 2021 · 3 comments
Labels
status: on hold Not addressed yet or waiting other issue type: bug

Comments

@fbertone
Copy link

Hi,
as I mentioned in #141 I'm having an issue when scrolling horizontally.
At the beginning the view is well aligned, but when I start scrolling the view gets unaligned.

  • Here you can see a recording of 1 day: the more I scroll to the future, the more the view gets unaligned:

https://www.udrop.com/61We/recording_20211013_100330.mp4

  • Here you can see a recording of 5 days: in this case the unalignment seems more random:

https://www.udrop.com/61Wf/recording_20211013_100435.mp4

(I guess the files will be deleted after 3 days)

@pdpino
Copy link
Collaborator

pdpino commented Oct 13, 2021

Thanks for the demo! I understand the issue. Bugs have high priority, so I will try to address this ASAP

It may be related to the following:

  • Are you using portrait or landscape mode?
  • Or, are you opening the app in one mode (e.g. portrait), and then changing to the other (e.g. landscape)? And only on the second mode the misalignment occurs? Currently the library is not responsive to orientation changes, so this would be a known bug: It is not responsive to orientation change. #38

A long-term solution for that bug is tricky and may not be backward-compatible (that's why we haven't solved it), but we may be able to apply a hot-fix for now (if we determine this is the cause of the issue)


Also, could you kindly provide the following, so I can try and reproduce this:

  • react-native and react versions you are using
  • react-native-week-view version (npm version, directly from master, etc)
  • device you are using (emulator/physical, android/ios, screen orientation, etc)
  • Minimal <WeekView /> call example

@fbertone
Copy link
Author

I've just identified that the issue is caused by a padding set on the outer view:

<View
  style={{
    flexDirection: "row",
    padding: 20
  }}
>
  
  <WeekView />
  
</View>

Yep, I've also witnessed the "not responsive to orientation changes" so I've blocked the screen rotation altogether :)

@pdpino
Copy link
Collaborator

pdpino commented Oct 16, 2021

I've just identified that the issue is caused by a padding set on the outer view

Ok, so this issue would be about responsiveness in the horizontal axis (similar to the other issue, which also involves responsiveness).
And the workaround would be: let the <WeekView/> component use the full width of the screen.

I'm afraid solving the whole responsiveness issue is tricky and a big change for the library, so I'm not working on it right now. I hope we can solve it some time soon

@pdpino pdpino added the status: on hold Not addressed yet or waiting other issue label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on hold Not addressed yet or waiting other issue type: bug
Projects
None yet
Development

No branches or pull requests

2 participants